? ? PHP 8.x Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
19 Mar 2022

Summary of Changes

On PHP 8.1 htmlspecialchars is not allowing anymore null values. The HTMLView escape function needs to handle this.

Testing Instructions

  • Run the webserver on PHP 8.1
  • Create an article custom field
  • Open the fields list in the back end

Actual result BEFORE applying this Pull Request

Warning is displayed:
: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /libraries/src/MVC/View/HtmlView.php on line 257

Expected result AFTER applying this Pull Request

Field group value is empty.

avatar laoneo laoneo - open - 19 Mar 2022
avatar laoneo laoneo - change - 19 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Mar 2022
Category Libraries
avatar laoneo laoneo - change - 19 Mar 2022
Labels Added: ? ?
avatar alikon
alikon - comment - 20 Mar 2022

I have tested this item successfully on 19a4a28


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37319.

avatar alikon alikon - test_item - 20 Mar 2022 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 20 Mar 2022

I have tested this item successfully on 19a4a28


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37319.

avatar dgrammatiko dgrammatiko - test_item - 20 Mar 2022 - Tested successfully
avatar alikon
alikon - comment - 21 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37319.

avatar alikon alikon - change - 21 Mar 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 21 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37319.

avatar bembelimen bembelimen - change - 24 Mar 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-03-24 20:13:11
Closed_By bembelimen
Labels Added: ? PHP 8.x
Removed: ?
avatar bembelimen bembelimen - close - 24 Mar 2022
avatar bembelimen bembelimen - merge - 24 Mar 2022
avatar bembelimen
bembelimen - comment - 24 Mar 2022

Thx

Add a Comment

Login with GitHub to post a comment