[#37310] - [4.1] Lazy Stylesheet comment
- Fixed in Code Base
- 18 Mar 2022
- Medium
- Build: 4.1-dev
- # 37310
- Diff
- brianteeman:patch-3
User tests: Successful: Unsuccessful:
#3241 added the ability to lazy load a stylesheet. This PR just adds a comment to explain why and how it works.
I spent ages looking at it and had to go back to the original PR before I understood and most users won't think to do that. It was even commented in the original PR that this needed exmplaining
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
| Labels |
Added:
?
|
||
I have tested this item
There is nothing to teast, really. I just had a look at the commit.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37310.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37310.
| Labels |
Added:
?
|
||
did you really need to merge the branch? Everytime you do that you reset all the tests.
Yes, when the branch is not up to date, I can't merge.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-18 17:45:20 |
| Closed_By | ⇒ | laoneo |
Thanks!
rtc status didn't change even after a merge, if rtc still value something...
Then you need to change the user settings on github. Its a pointless action just to work around an acl rule
I don't set the rules. It's an inner circle who does. In the past it was more relaxed, people who were maintainers were also administrators. Now times are different.
You missed the point. If the ACL prevents you from merging unless the branch is upto date but allows you to update the branch yourself then the ACL rule is useless.
I have tested this item✅ successfully on cc39c37
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37310.