?

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
6 Jun 2014

Issue

Based on a forum post (http://forum.joomla.org/viewtopic.php?f=617&t=847166) there is an issue with real_escape_string in Joomla 2.5.
This is due to how we set up the connection charset.
On the PHP manual (http://www.php.net/manual/en/mysqli.set-charset.php) it says:

This is the preferred way to change the charset. Using mysqli_query() to set it (such as SET NAMES utf8) is not recommended.

In J3.3 we don't have this issue because this change was already done somewhere during 3.0 alpha.

Testing

According to the forum post, the issue can for example be seen if you use multibytes characters in a search/filter.
However it will not show if the database is set up to use utf8 charset in the connection by default (which today is standard). So it's enviroment related.

avatar Bakual Bakual - open - 6 Jun 2014
avatar infograf768
infograf768 - comment - 7 Jun 2014

No unwanted effects here on a normal setting.

avatar infograf768 infograf768 - close - 17 Jun 2014
avatar infograf768 infograf768 - reference | - 17 Jun 14
avatar infograf768 infograf768 - merge - 17 Jun 2014
avatar infograf768 infograf768 - close - 17 Jun 2014
avatar infograf768 infograf768 - change - 17 Jun 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-06-17 06:52:29
avatar infograf768
infograf768 - comment - 17 Jun 2014

User confirms patch is fine. Merging.

avatar Bakual Bakual - head_ref_deleted - 17 Jun 2014

Add a Comment

Login with GitHub to post a comment