? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar anmode
anmode
17 Mar 2022

Pull Request for UI Improvement

Summary of Changes

Just change the position of the side logo after collapsing it is not aligned with the rest icon present bottom to it if we align the logo with the rest icons it looks good I think!

Testing Instructions

just login to your dashboard and see the logo position after collapsing it.

Actual result BEFORE applying this Pull Request

WhatsApp Image 2022-03-17 at 12 03 56 PM (1)

Expected result AFTER applying this Pull Request

WhatsApp Image 2022-03-17 at 12 03 56 PM

Documentation Changes Required

No document changes.

avatar anmode anmode - open - 17 Mar 2022
avatar anmode anmode - change - 17 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Mar 2022
Category Repository NPM Change
avatar anmode anmode - change - 17 Mar 2022
Labels Added: NPM Resource Changed ?
avatar brianteeman
brianteeman - comment - 17 Mar 2022

Please use logical css properties. That way it will also be correct for right to left RTL languages

avatar anmode
anmode - comment - 17 Mar 2022

Actually i didn't know which property will be suitable, I'll try to figure out and commit it soon.

avatar richard67
richard67 - comment - 17 Mar 2022

Actually i didn't know which property will be suitable, I'll try to figure out and commit it soon.

@anmode Check https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Logical_Properties

avatar simbus82
simbus82 - comment - 17 Mar 2022

I think it's enough to add this
simbus82@e991e80

Even if the animation, then, will not be beautiful...

avatar anmode
anmode - comment - 17 Mar 2022

Actually i didn't know which property will be suitable, I'll try to figure out and commit it soon.

@anmode Check https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Logical_Properties

sure! Thanks

avatar anmode
anmode - comment - 17 Mar 2022

I think it's enough to add this simbus82@e991e80

Even if the animation, then, will not be beautiful...

yeah! This is fine and solved the problem too.

avatar richard67
richard67 - comment - 17 Mar 2022

@anmode Currently your PR shows zero changes, i.e. you've reverted all. Will there come some changes?

avatar anmode
anmode - comment - 17 Mar 2022

@anmode Currently your PR shows zero changes, i.e. you've reverted all. Will there come some changes?

yess I am committing changes....soon pushing

avatar anmode
anmode - comment - 17 Mar 2022

@anmode Currently your PR shows zero changes, i.e. you've reverted all. Will there come some changes?

done! I had committed all the changes. idk why build fails! I need to correct it? help me out in that little please

avatar brianteeman
brianteeman - comment - 17 Mar 2022

I have tested this item successfully on 2a0a9b5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37303.

avatar brianteeman brianteeman - test_item - 17 Mar 2022 - Tested successfully
avatar Quy
Quy - comment - 17 Mar 2022

I have tested this item successfully on 2a0a9b5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37303.

avatar Quy Quy - test_item - 17 Mar 2022 - Tested successfully
avatar Quy Quy - change - 17 Mar 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 17 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37303.

avatar bembelimen bembelimen - change - 17 Mar 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-03-17 20:48:01
Closed_By bembelimen
Labels Added: ?
avatar bembelimen bembelimen - close - 17 Mar 2022
avatar bembelimen bembelimen - merge - 17 Mar 2022
avatar bembelimen
bembelimen - comment - 17 Mar 2022

Thanks @anmode for your first contribution. Keep up the good work! ?

avatar anmode
anmode - comment - 17 Mar 2022

Thanks @anmode for your first contribution. Keep up the good work! ?

Thanks a lot ?.

Add a Comment

Login with GitHub to post a comment