No Code Attached Yet a11y J4 Issue
avatar chmst
chmst
16 Mar 2022

I got an E-mail from a blind user:

[..] with the latest update to version 4.1.0 and the addition of the Source Code Plus option, I can no longer edit the source code of an article.
[..]
I'm not sure if this is Joomla itself or an update with the Tiny MCE Editor but, now that it is using an iFrame it is unusable.
Upon entering the iFrame, I seem to be presented with an editable field along with a read only list of the source code. Therefore I can not edit a line of code or insert HTML into the source code anymore.
[..]

avatar chmst chmst - open - 16 Mar 2022
avatar brianteeman
brianteeman - comment - 16 Mar 2022

checking

BTW its actually codemirror that is being opened in the iframe

avatar chmst
chmst - comment - 16 Mar 2022

Thank you. I was wondering as I cannot find an iframe for TinyMCE source code.

avatar brianteeman
brianteeman - comment - 16 Mar 2022

The code is located https://github.com/joomla/joomla-cms/tree/4.1-dev/build/media_source/plg_editors_tinymce/js/plugins/highlighter

And when built it lives in media/plg_editors_tinymce/js/plugins/highlighter

avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2022
Labels Added: No Code Attached Yet a11y J4 Issue
avatar joomla-cms-bot joomla-cms-bot - labeled - 16 Mar 2022
avatar dgrammatiko
dgrammatiko - comment - 16 Mar 2022

@chmst what where the steps they used?

I used option + F10 to get to the toolbar and with enter on the code button the focus is moved in the iframe of the codemirror.

avatar chmst
chmst - comment - 16 Mar 2022

It is with screen reader. Unfortunately I have no clue how this works or how it worked before J4. I am very impressed by this letter and hope that we get much feedback from users.

She wrote:
[..] Joomla has on the whole been accessible to myself using Apple's Voiceover component with the screen reader function.
I have taught myself a great deal using Joomla over the past 6 years and I am very grateful to the entire team for making this possible. I have constructed a number of sites using both Joomla 3.x and now 4.x but

... continues as in my first post.

Will try to get more info, and thanks for investigating

avatar dgrammatiko
dgrammatiko - comment - 16 Mar 2022

@chmst can you ask them to disable the code highlighting for the time?
I will try to test with voice over later today

avatar brianteeman
brianteeman - comment - 16 Mar 2022

It seemed ok to me on windows with narrator but there are so many variables in play. browser, os, screenreader etc

avatar chmst
chmst - comment - 16 Mar 2022

I tried myself to swithc off the highlighting. In the tinyMCE plugin set the parameter "Source Code Highlighting" OFF.
But this has no effect. The output highlighted.

avatar dgrammatiko
dgrammatiko - comment - 16 Mar 2022

The output highlighted.

That's a bug then

@chmst #37298

avatar richard67 richard67 - change - 16 Mar 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-03-16 19:13:26
Closed_By richard67
avatar richard67 richard67 - close - 16 Mar 2022
avatar richard67
richard67 - comment - 16 Mar 2022

Closing as having a pull request. Please test #37298 . Thanks in advance.

avatar dgrammatiko
dgrammatiko - comment - 16 Mar 2022

@richard67 the PR only solves the bug for the switch, the a11y part of this issue is still under investigation

avatar richard67
richard67 - comment - 16 Mar 2022

@dgrammatiko Does your PR solve the issue completely? Or only partly?

avatar richard67 richard67 - change - 16 Mar 2022
Status Closed New
Closed_Date 2022-03-16 19:13:26
Closed_By richard67
avatar richard67 richard67 - reopen - 16 Mar 2022
avatar richard67
richard67 - comment - 16 Mar 2022

Ah you were faster. Yes, I just noticed.

avatar chmst
chmst - comment - 16 Mar 2022

Thanks for the first part!

avatar brianteeman
brianteeman - comment - 29 Mar 2022

Is there any more feedback on what needs to be done?

avatar chmst chmst - change - 30 Mar 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-03-30 15:30:58
Closed_By chmst
avatar chmst chmst - close - 30 Mar 2022
avatar chmst
chmst - comment - 30 Mar 2022

Closing this as #37298 solved the problem.

Got a response right now:

_All your hard work has paid off and the Source Code is now editable again using Apple Voiceover, it functions exactly as it used to. I can access the source code on an article and perform the required tasks.

This is wonderful news and I am so very grateful to yourself and all those who work so hard at keeping Joomla working so smoothly._

:)

Add a Comment

Login with GitHub to post a comment