By review I'd say this PR is correct because a few lines below, in line 23, we already use the right path for the JS file.

By review I'd say this PR is correct because a few lines below, in line 23, we already use the right path for the JS file.

thats why I suggested it ;)

What I still don't understand is why I could not reproduce the issue here. But I have tested that with this PR the installation form still looks ok here with LTR and RTL.

@richard67 @brianteeman on my local server with either paths (just template.css or [installation/template/css/template.css I get the correct result but lets use the stricter one (the line is missing the options array for 'relative' => true and I'm guessing the logic is a bit flaky on windows[?])
Unless if adding ->registerAndUseStyle('template.installation', 'template' . ($this->direction === 'rtl' ? '-rtl' : '') . '.css', ['version' => 'auto', 'relative' => true],[]) is working, then this is a better solution

@brianteeman can you please confirm that the latest commit works as expected on your env?

give me 5

BTW there's a PHP notice in the last page

The solution is adding

						<?php if (empty($element)) : ?>
							<?php continue; ?>
						<?php endif; ?>

after

I have tested this item ? unsuccessfully on 1e6b461

I have tested this item ✅ successfully on 1e6b461

I have tested this item ✅ successfully on 245c81f

Issue can be reproduced by creating a file "template.css" in the Joomla root. This can be an empty file.

Without the PR, installation form is not styled.

With the PR it is.

@brianteeman For some reason your test result had an old commit reference. Not your fault, I think, but maybe a caching issue of the tracker. I've restored your test result in the tracker so it is properly counted.

RTC

RTC

Thanks!