Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#3729] - defined('_JEXEC') and defined('JPATH_BASE') --> defined('JPATH_PLATFORM') for the folder /libraries/cms/

? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
6 Jun 2014

@mbabker and @bakual

Here is the PR.

Do we need a Tracker with testing? (how can we test it?)

avatar zero-24 zero-24 - open - 6 Jun 2014
avatar Bakual
Bakual - comment - 6 Jun 2014

I don't think we need a tracker

As an explanation, this is an attemp to standardise the useage of our defined('foo') or die statement.
Currently in the libraries folder we use:

  • 33 times defined('JPATH_BASE') or die;
  • 26 times defined('_JEXEC') or die;
  • ~550 times defined('JPATH_PLATFORM') or die;
avatar zero-24
zero-24 - comment - 6 Jun 2014

@Bakual
So should we also fix the libraries\legacy folder? (3x '_JEXEC')

At libraries\fof we have also one
defined('_JEXEC') or die;

avatar Bakual
Bakual - comment - 6 Jun 2014

I think we can do it for the legacy folder as well. I would however leave fof alone.

avatar phproberto
phproberto - comment - 6 Jun 2014

Can we please send different PRs to ease conflicts resolution?

avatar zero-24
zero-24 - comment - 6 Jun 2014

@phproberto

Can we please send different PRs to ease conflicts resolution?

different for what? folder? So one for cms and one for legacy?

avatar zero-24
zero-24 - comment - 6 Jun 2014

@Bakual i have add the 3 at the legacy folder now.

avatar Bakual Bakual - change - 8 Jun 2014
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-06-08 19:20:40
avatar Bakual Bakual - close - 8 Jun 2014
avatar Bakual Bakual - close - 8 Jun 2014
avatar Bakual
Bakual - comment - 8 Jun 2014

Merged from code review. Thanks!

avatar zero-24 zero-24 - head_ref_deleted - 21 Jul 2014

Add a Comment

Login with GitHub to post a comment