[#37289] - [5.3] Using languagecode system parameters to display lang tag in assoc badges
- Closed
- 28 Nov 2024
- Medium
- Build: 4.1-dev
- # 37289
- Diff
- infograf768:4.1-dev
User tests: Successful: Unsuccessful:
Solving #37228 (comment)
Summary of Changes
Checking in each case if the language code plugin is enabled and if so, modify the associations badges to use the lang tag defined by the plugin.
Testing Instructions
Create a multilingual site.
Enable the languagecode system plugin and give a new lang tag value for a language.
Example:
Expected result AFTER applying this Pull Request
Every occurrence of a badge displaying the installed language tag will display the new tag.
- com_associations, com_contact, com_categories, com_menus, com_newsfeeds
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_categories com_contact com_content com_menus com_newsfeeds Modules |
| Labels |
Added:
?
|
||
| Title |
|
||||||
@richard67
Please do whatever is better.
This pull request has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
|
||
This pull request has been automatically rebased to 5.0-dev.
Not sure about this. With the patch applied I see the language tag I entered in the Articles list. But I don't see any language tags in the Menus Dashboard or in the admin Main Menu. The html tags contains the tag I entered <html lang="de-ch" dir="ltr">. Is this is a valid test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37289.
This pull request has been automatically rebased to 5.1-dev.
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
@infograf768 can you resolve the conflicts so the pull request can get a test?
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
As @infograf768 has retired I have recreated the PR without the merge conflicts #44551
Can be closed as we have a replacement
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-11-28 15:49:40 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
Feature
Conflicting Files
PR-5.3-dev
Removed: ? ? |
||
Maybe it should be rebased to 4.2-dev because it’s some kind of new feature? If so, I will help if necessary e.g. if JM has little time.