? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
16 Mar 2022

Solving #37228 (comment)

Summary of Changes

Checking in each case if the language code plugin is enabled and if so, modify the associations badges to use the lang tag defined by the plugin.

Testing Instructions

Create a multilingual site.
Enable the languagecode system plugin and give a new lang tag value for a language.

Example:
Screenshot 2022-03-16 at 11 29 48

Expected result AFTER applying this Pull Request

Every occurrence of a badge displaying the installed language tag will display the new tag.

Screenshot 2022-03-16 at 11 31 48

Screenshot 2022-03-16 at 11 33 07

Screenshot 2022-03-16 at 11 34 47

  • com_associations, com_contact, com_categories, com_menus, com_newsfeeds
avatar infograf768 infograf768 - open - 16 Mar 2022
avatar infograf768 infograf768 - change - 16 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2022
Category Administration com_associations com_categories com_contact com_content com_menus com_newsfeeds Modules
avatar infograf768 infograf768 - change - 16 Mar 2022
Labels Added: ?
avatar infograf768 infograf768 - change - 16 Mar 2022
Title
[4.1] Using languagecode system parameters to display lang tag in
[4.1] Using languagecode system parameters to display lang tag in assoc badges
avatar infograf768 infograf768 - edited - 16 Mar 2022
avatar infograf768 infograf768 - change - 17 Mar 2022
The description was changed
avatar infograf768 infograf768 - edited - 17 Mar 2022
7264ace 17 Mar 2022 avatar infograf768 oops
avatar richard67
richard67 - comment - 19 Mar 2022

Maybe it should be rebased to 4.2-dev because it’s some kind of new feature? If so, I will help if necessary e.g. if JM has little time.

avatar infograf768
infograf768 - comment - 20 Mar 2022

@richard67
Please do whatever is better.

avatar HLeithner
HLeithner - comment - 27 Jun 2022

This pull request has automatically rebased to 4.2-dev.

avatar joomla-bot
joomla-bot - comment - 27 Jun 2022

This pull requests has been automatically converted to the PSR-12 coding standard.

avatar infograf768 infograf768 - change - 28 Jun 2022
Labels Added: ?
avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 5.0-dev.

avatar ceford
ceford - comment - 14 Sep 2023

Not sure about this. With the patch applied I see the language tag I entered in the Articles list. But I don't see any language tags in the Menus Dashboard or in the admin Main Menu. The html tags contains the tag I entered <html lang="de-ch" dir="ltr">. Is this is a valid test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37289.

avatar brianteeman
brianteeman - comment - 14 Sep 2023

@ceford this is a pr with merge conflicts that prevent testing

image

avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 5.1-dev.

avatar HLeithner
HLeithner - comment - 24 Apr 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
[4.1] Using languagecode system parameters to display lang tag in assoc badges
[5.2] Using languagecode system parameters to display lang tag in assoc badges
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar fgsw
fgsw - comment - 2 Sep 2024

@infograf768 can you resolve the conflicts so the pull request can get a test?

avatar HLeithner
HLeithner - comment - 2 Sep 2024

This pull request has been automatically rebased to 5.3-dev.

avatar HLeithner HLeithner - change - 2 Sep 2024
Title
[5.2] Using languagecode system parameters to display lang tag in assoc badges
[5.3] Using languagecode system parameters to display lang tag in assoc badges
avatar HLeithner HLeithner - edited - 2 Sep 2024

Add a Comment

Login with GitHub to post a comment