User tests: Successful: Unsuccessful:
Partial PR for #36370
see #36370 (comment)
Status | New | ⇒ | Pending |
Category | ⇒ | Installation Language & Strings |
I have tested this item
By review.
@brianteeman
I noticed that the language strings JLIB_UPDATER_ERROR_COLLECTION_FOPEN and JLIB_UPDATER_ERROR_COLLECTION_OPEN_URL aren't used in any file? Can you point me where the strings are used?
They are some of the compound strings so you wont be able to seatch the code base for them
I have tested this item
I tried differente ways (on WAMP) but was also unable to reproduce the error. But as they are valid text strings I agree with @richard67
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
Language Change
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-02 02:12:54 |
Closed_By | ⇒ | Quy |
Thanks
By review I think the added stings are ok, but I haven't really managed to get one of them shown when making an installation and choosing to install some languages at the end. E.g. I disabled the allow_url_fopen setting but did not get the JLIB_UPDATER_ERROR_COLLECTION_FOPEN message shown anywhere.