? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
16 Mar 2022

Partial PR for #36370
see #36370 (comment)

avatar brianteeman brianteeman - open - 16 Mar 2022
avatar brianteeman brianteeman - change - 16 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2022
Category Installation Language & Strings
avatar richard67
richard67 - comment - 17 Mar 2022

By review I think the added stings are ok, but I haven't really managed to get one of them shown when making an installation and choosing to install some languages at the end. E.g. I disabled the allow_url_fopen setting but did not get the JLIB_UPDATER_ERROR_COLLECTION_FOPEN message shown anywhere.

avatar richard67
richard67 - comment - 19 Mar 2022

I have tested this item successfully on e84078d

By review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37286.

avatar richard67 richard67 - test_item - 19 Mar 2022 - Tested successfully
avatar RickR2H
RickR2H - comment - 25 Mar 2022

@brianteeman
I noticed that the language strings JLIB_UPDATER_ERROR_COLLECTION_FOPEN and JLIB_UPDATER_ERROR_COLLECTION_OPEN_URL aren't used in any file? Can you point me where the strings are used?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37286.

avatar brianteeman
brianteeman - comment - 25 Mar 2022

They are some of the compound strings so you wont be able to seatch the code base for them

avatar RickR2H
RickR2H - comment - 25 Mar 2022

I have tested this item successfully on e84078d

I tried differente ways (on WAMP) but was also unable to reproduce the error. But as they are valid text strings I agree with @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37286.

avatar RickR2H RickR2H - test_item - 25 Mar 2022 - Tested successfully
avatar RickR2H RickR2H - change - 25 Mar 2022
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 25 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37286.

avatar brianteeman brianteeman - change - 1 Apr 2022
Labels Added: ? Language Change ?
avatar Quy Quy - change - 2 Apr 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-04-02 02:12:54
Closed_By Quy
avatar Quy Quy - close - 2 Apr 2022
avatar Quy Quy - merge - 2 Apr 2022
avatar Quy
Quy - comment - 2 Apr 2022

Thanks

Add a Comment

Login with GitHub to post a comment