[#37279] - [4.1] Composer update maximebf/debugbar to fix PHP 8.1 deprecations of the debug bar
- Fixed in Code Base
- 15 Mar 2022
- Medium
- Build: 4.1-dev
- # 37279
- Diff
- richard67:4.1-dev-composer-update-maximebf-debugbar
User tests: Successful: Unsuccessful:
Pull Request for Issue #37274 (part).
Replaces PR #37278 .
Summary of Changes
This pull requests updates the composer dependency "maximebf/debugbar" to their latest version 1.18 which fixes a lot of PHP 8.1 deprecations.
It should fix almost all of the deprecation notices reported in the issue except of the 2 mentioned in this comment here: #37274 (comment) .
These are already fixed in the upstream repository with this PR, which has been merged on February 11: maximebf/php-debugbar#498 , i.e. one day after their latest version 1.18 was released. So for these 2 we have to wait for the next version.
Testing Instructions
See issue #37274 .
Actual result BEFORE applying this Pull Request
Lots of deprecation notices about the debug bar with PHP 8.1, and one for the calendar field.
Expected result AFTER applying this Pull Request
Deprecation notices about the debug bar disappeared.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Composer Change |
I have tested this item
Deprecated
: Implicit conversion from float -INF to int loses precision in
C:\OpenServer\domains\joomla.test\libraries\vendor\maximebf\debugbar\src\DebugBar\DataFormatter\DataFormatter.php
on line
81
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37279.
I have tested this item
Deprecated
: Implicit conversion from float -INF to int loses precision in
C:\OpenServer\domains\joomla.test\libraries\vendor\maximebf\debugbar\src\DebugBar\DataFormatter\DataFormatter.php
on line
81
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37279.
@exstreme Please read again the description of this pull request and read the testing instructions. This PR does not claim to solve that one deprecation notice which you are referring to. So if that was the only one which was remaining, your unsuccessful test result is not justified, and it should be successful.
Update: Sorry, I missed that they are located also in the debug bar. These should be solved with the next version of the debug bar, which unfortunately is not available yet. The corresponding commit in their repository is maximebf/php-debugbar#498 .
I will update the description of this PR here to make clear that it does not fix that one. Could you then think over your test result? Thanks in advance.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37279.
Thanks for testing.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
Composer Dependency Changed
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37279.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37279.
I've subscribed to get notified when they make a new release of the debug bar, so if that happens I will adjust this PR if not merged yet or make a new one.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-15 23:42:02 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thankyou!
I have tested this item✅ successfully on 85b5d06
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37279.