[#37236] - [4.1] Space at bottom of sidebar for non logged user.
- Fixed in Code Base
- 18 Mar 2022
- Medium
- Build: 4.1-dev
- # 37236
- Diff
- anmode:space-nonlogged-user
User tests: Successful: Unsuccessful:
Pull Request for Issue #37171
Backend Login page -> There's a little space below the left blue bar. I believe this only shows when there are NO buttons in the top header. We have disabled all those buttons for not logged in users
Summary of Changes
Just changed the viewport height so after disabling the login button at the top of the bar.
Testing Instructions
I made changes in the scss folder so after recreating the media folder(creating CSS files) the changes will be reflected on the localhost.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
3165271449.mp4
Documentation Changes Required
No changes required
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Title |
|
||||||
| Title |
|
||||||
Another solution is to add flex-grow-1 to:
Either use class or css, but not both. Since there is a class for it, use it instead of adding css, but that is just my opinion.
Either use class or CSS, but not both. Since there is a class for it, use it instead of adding CSS, but that is just my opinion.
I just add CSS and the class is already defined may be used somewhere else in the codebase.
flex-grow-1 is a standard Bootstrap class. Either way will work. It is up to the release maintainer to decide.
flex-grow-1is a standard Bootstrap class. Either way will work. It is up to the release maintainer to decide.
oh okay thanks a lot.
| Category | Repository NPM Change | ⇒ | Administration Templates (admin) |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37236.
I have tested this item
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37236.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37236.
| Labels |
Added:
?
Removed: NPM Resource Changed |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-18 12:20:16 |
| Closed_By | ⇒ | laoneo |
Thanks!!
I have tested this item✅ successfully on 3f49273
✅ successfully on b1fa223
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37236.