[#37225] - Solved the problem of little space at blue sidebar issue #37171
- Closed
- 9 Mar 2022
- Medium
- Build: 4.1-dev
- # 37225
- Diff
- anmode:space-bottom-non-loggeduser
User tests: Successful: Unsuccessful:
Pull Request for Issue #37171
Backend Login page -> There's a little space below the left blue bar. I believe this only shows when there are NO buttons in the top header. We have disabled all those buttons for not logged in users
Summary of Changes
Just changed the viewport height so after disabling the login button at the top of bar.
Testing Instructions
I made changes in scss folder so after recreating the media folder(creating CSS files) the changes will be reflected on the localhost.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
This space has been filled
Documentation Changes Required
No changes required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
I have tested this item
? unsuccessfully on ebc6f64Why did you not create the pull request the way that was suggested. This is an ugly hackThis comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37225.
I didn't get it pls would u guide a little way?
Actually i just change the css file so the issue may be solved.
Why did you not create the pull request the way that was suggested.
Why did you not create the pull request the way that was suggested.
Actually i m unsure about it. May u refer so i can go through it pls. Sorry for that!
With your ugly hack look at the right - you have a scrollbar. This is because you have changed the height of the wrong element.
Now look at it when you use the css that was suggested to use.
With your ugly hack look at the right - you have a scrollbar. This is because you have changed the height of the wrong element.
Now look at it when you use the css that was suggested to use.
Ohh thanks a lot i got it now.
Sorry for it. Actually i learn a lot today about joomla codebase while working on this issue.
Now may i generate a new pR?
Now may i generate a new pR?
Just update this PR with the correct code
Now may i generate a new pR?
Just update this PR with the correct code
Sure ,Thanks! a lot
If working with a local clone, don’t forget to push to the remote after having made your changes and committed in your local clone.
If working with a local clone, don’t forget to push to the remote after having made your changes and committed in your local clone.
Oh okay sure I'll keep that in my mind.
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tried to make the right changes now, I believe it will test successfully. I do not know much of git and GitHub commands, but I will be learning in this process. Just a little guidance is required from your side. This is short video
3165271449.mp4
If this PR is messed up than may i generate a new PR? again making new branch from 4.1-dev and then pushing it.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-09 11:13:55 |
| Closed_By | ⇒ | anmode |
I have tested this item? unsuccessfully on ebc6f64
Why did you not create the pull request the way that was suggested. This is an ugly hack
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37225.