Joomla! Issue Tracker | Joomla! CMS #37217 - Remove Unused Method Again After Merge Error

Closed
7 Mar 2022
Medium
Build: 4.1-dev
# 37217
Diff
PhilETaylor:patch-337

Pending

User tests: Successful: Unsuccessful:

PhilETaylor
6 Mar 2022

#37212

So ignoring the "Files Changed" Tab ... look at the commits tab on the older PRs.

#34060 = I remove the method getData which was merged by you at 8:38pm

#34118 = I remove the method _getList f6effc7

You then merge 4.0-dev incorrectly at 8:41pm - thus resulting in adding back some code... leading to the +/- we see in the Files Changed Tab here: https://github.com/joomla/joomla-cms/pull/34118/files

So, my PRs were to remove getData and getList methods from this file, and thus we need to do that again... by removing the getData

//cc @joomdonation @richard67

96af3c1 6 Mar 2022

Remove Unused Method Again After Merge Error

PhilETaylor - open - 6 Mar 2022

PhilETaylor - change - 6 Mar 2022

Status

New

⇒

Pending

joomla-cms-bot - change - 6 Mar 2022

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#37217] - Remove Unused Method Again After Merge Error

Add a Comment

Status	Pending	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2022-03-07 18:40:37
Closed_By		⇒	PhilETaylor
Labels	Added: ?