[#37201] - [4.1] com_scheduler reset task counters
- Closed
- 25 May 2022
- Medium
- Build: 4.1-dev
- # 37201
- Diff
- brianteeman:task_reset_count
User tests: Successful: Unsuccessful:
Pull Request for Issue #36457 .
Summary of Changes
So lets say my task has been constantly failing and I have 3123 Times Failed. I have fixed the problem and want to reset the stats to that I can keep an eye on it, there is no way to do that without deleting the task and creating a new one.
Add reset button to the counter for times executed and times failed
Testing Instructions
Apply the pr
Create a task and run it a few times (or update the db directly)
Press the reset button and save the task
Check the task again and the counts have been reset to 0
Actual result BEFORE applying this Pull Request
Not possible
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
I have tested this item
The patch behaved as described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37201.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37201.
@brianteeman Does it really need 2 new field types? They have the same code except of the value of the $type variable. Would it not work with one new common type?
@richard67 It would (i think) but then this is just a copy of the same field in com_banners
To me that seems all to be one kind of field which should have a generic name like e.g. ResetableCounter or so. But that's maybe out of scope now.
It would make more sense to create a generic field "ResetField" and abstract "ClicksField" from it and deprecate the field. Then we don't need to use 3 copies of one field.
actually we don't need to deprecated the clicksfield we can just simple remove it because it's not part of the b/c policy.
closing and will make a new fieldtype
If someone wants to create a new fieldtype for this then go for it. Personally I dont see the need
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-06 21:30:39 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2022-03-06 21:30:39 | ⇒ | |
| Closed_By | brianteeman | ⇒ | |
| Labels |
Removed:
?
|
||
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-05-25 19:30:29 |
| Closed_By | ⇒ | brianteeman |
I have tested this item✅ successfully on a997f98
It works very well, but I feel that the restart action is too fast and permanent. Could it be affordable to add a confirmation request from the user?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37201.