No Code Attached Yet
avatar jjnxpct
jjnxpct
2 Mar 2022

What needs to be fixed

Backend Login page -> There's a little space below the left blue bar. I believe this only shows when there are NO buttons in the top header. We have disabled all those buttons for not logged in users.

Why this should be fixed

Just for better looks ;-)

How would you fix it

body.com_login :
div#wrapper -> Add: flex-grow: 1;

Side Effects expected

None

Not sure if this is the right place to create this issue? maybe there is a rep for just the backend template?

2022-03-02_09-35-31

avatar jjnxpct jjnxpct - open - 2 Mar 2022
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 2 Mar 2022
avatar richard67
richard67 - comment - 2 Mar 2022

Not sure if this is the right place to create this issue? maybe there is a rep for just the backend template?

It is the right place here. There is a backend template repo, but that was used in past and is not active anymore.

avatar jjnxpct jjnxpct - change - 2 Mar 2022
Title
Backend login page
Backend login page -> space bottom of the page
avatar jjnxpct jjnxpct - edited - 2 Mar 2022
avatar brianteeman
brianteeman - comment - 2 Mar 2022

confirmed when the site preview button is removed

avatar brianteeman
brianteeman - comment - 3 Mar 2022

@jjnxpct are you able to submit a pull request to fix this?

avatar jjnxpct
jjnxpct - comment - 4 Mar 2022

@brianteeman I have never done that before ;-) Not sure how to do it. But I am willing to learn.

I work with VSCode and we also work with GitHub within VScode. But mainly for our own projects. We don't use pull requests.

To do this I would need to first clone this repo and then change some code. But then? In stead of committing I would need to 'upload' it as a pull request?

avatar richard67
richard67 - comment - 4 Mar 2022

@jjnxpct Fork the repo, clone your fork so you have it locally, create a new branch based on the 4.1-dev branch, make your changes in that new branch, push them to your remote and there use the UI on GitHub to create a pull request from that branch.

That's how I would do it. Maybe there are more comfortable ways in VScode, I don't know.

avatar anmode
anmode - comment - 6 Mar 2022

Heyy I know how to solve it but I cannot replicate the error in my backend login page there is nothing this type of issue. You check it out I had made a Vimeo https://vimeo.com/685087891/35176c2781

avatar jjnxpct
jjnxpct - comment - 6 Mar 2022

@anmode You need to disable the button in the top bar (that takes you to the website) so there are no buttons there. Only then will you see the space below.

avatar anmode
anmode - comment - 7 Mar 2022

.

@anmode You need to disable the button in the top basr (that tales you to the website) so there are no buttons there. Only then will you see the space below.

ohh okay I got it :) thanks

avatar jjnxpct
jjnxpct - comment - 7 Mar 2022

Hi! As stated in my first post here I think this might be a fix in the CSS:
body.com_login -> div#wrapper -> Add: flex-grow: 1;
/media/templates/administrator/atum/scss/blocks/_global.scss

But this changing the #wrapper here might have impact on other pages as well?
I found the specific login CSS here:
/media/templates/administrator/atum/scss/blocks/_login.scss

Hope this helps.

avatar anmode
anmode - comment - 10 Mar 2022

Disabling buttons via visibility: hidden need no change in the CSS files.

avatar Quy Quy - close - 14 Mar 2022
avatar Quy
Quy - comment - 14 Mar 2022

Please test PR #37236

avatar Quy Quy - change - 14 Mar 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-03-14 20:10:34
Closed_By Quy

Add a Comment

Login with GitHub to post a comment