? Pending

User tests: Successful: Unsuccessful:

avatar prakhar3062
prakhar3062
2 Mar 2022

Pull Request for Issue
Issue #37109
Summary of Changes
Put the logout button outside the dropdown menu.

Testing Instructions
After applying the patch, see the header of home page , you will see the result

Actual result BEFORE applying this Pull Request
68747470733a2f2f6973737565732e6a6f6f6d6c612e6f72672f75706c6f6164732f312f39363334316334343432313938626239366230323562663934356465363136322e706e67

Expected result AFTER applying this Pull Request

Web capture_1-3-2022_153056_localhost

Documentation Changes Required
No changes required

avatar prakhar3062 prakhar3062 - open - 2 Mar 2022
avatar prakhar3062 prakhar3062 - change - 2 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2022
Category Administration Templates (admin)
avatar rjharishabh
rjharishabh - comment - 2 Mar 2022

It should be a different button
see #37109 (comment)

avatar prakhar3062
prakhar3062 - comment - 2 Mar 2022

It should be a different button see #37109 (comment)

I tried but it is disturbing the ui at some or other point. Changes made by me is the one demanded by user

avatar laoneo
laoneo - comment - 2 Mar 2022

Please give the pr a proper title. Also make the changes in the file of the module itself. The template should not come with an override at all.

avatar prakhar3062 prakhar3062 - change - 2 Mar 2022
Title
Added the feature
Pull request for issue #37109
avatar prakhar3062 prakhar3062 - edited - 2 Mar 2022
avatar prakhar3062
prakhar3062 - comment - 2 Mar 2022

Please give the pr a proper title. Also make the changes in the file of the module itself. The template should not come with an override at all.

Didn't get you. Please explain more

avatar rjharishabh
rjharishabh - comment - 2 Mar 2022

What are you doing in this PR this should the PR title, not the issue number.
Mention the issue number in the PR description.

avatar rjharishabh
rjharishabh - comment - 2 Mar 2022

Please make changes in the module files, do not override the template
You have just copied and pasted the template override code provided by @ChristineWk

avatar brianteeman
brianteeman - comment - 2 Mar 2022

The title of the pull request becomes the message in the commit log. So it must be clear what it refers to or no one will ever see it in the future. If you look at the list of commits you should see why it is important https://github.com/joomla/joomla-cms/commits/4.1-dev

avatar prakhar3062 prakhar3062 - change - 2 Mar 2022
Title
Pull request for issue #37109
Fix the backend logout button issue #37163
avatar prakhar3062 prakhar3062 - edited - 2 Mar 2022
avatar prakhar3062
prakhar3062 - comment - 2 Mar 2022

Please make changes in the module files, do not override the template You have just copied and pasted the template override code provided by @ChristineWk

I took the idea from it as i don't get the idea where files are stored related to it but i will try to do with other possible way

avatar pritam825
pritam825 - comment - 2 Mar 2022

I have tested this item ? unsuccessfully on f93225a

unsuccessfull, because on clicking the logout icon ,the dropdown open which is not the expected result


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37165.

avatar pritam825 pritam825 - test_item - 2 Mar 2022 - Tested unsuccessfully
avatar richard67
richard67 - comment - 3 Mar 2022

Meanwhile we have another pull request from another author which claims to solve the same issue: #37183 .

avatar ChristineWk
ChristineWk - comment - 4 Mar 2022

I have tested this item ? unsuccessfully on f93225a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37165.

avatar ChristineWk ChristineWk - test_item - 4 Mar 2022 - Tested unsuccessfully
avatar C-Lodder
C-Lodder - comment - 8 Mar 2022

FYI this is semantically incorrect. You cannot have interactive elements inside a <button>

avatar brianteeman
brianteeman - comment - 8 Mar 2022

As explained several times already this should not be an override

avatar prakhar3062 prakhar3062 - change - 8 Mar 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-03-08 08:44:07
Closed_By prakhar3062
Labels Added: ?
avatar prakhar3062 prakhar3062 - close - 8 Mar 2022

Add a Comment

Login with GitHub to post a comment