User tests: Successful: Unsuccessful:
Pull Request for Issue
Issue #37109
Summary of Changes
Put the logout button outside the dropdown menu.
Testing Instructions
After applying the patch, see the header of home page , you will see the result
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No changes required
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) |
It should be a different button see #37109 (comment)
I tried but it is disturbing the ui at some or other point. Changes made by me is the one demanded by user
Please give the pr a proper title. Also make the changes in the file of the module itself. The template should not come with an override at all.
Title |
|
Please give the pr a proper title. Also make the changes in the file of the module itself. The template should not come with an override at all.
Didn't get you. Please explain more
What are you doing in this PR this should the PR title, not the issue number.
Mention the issue number in the PR description.
Please make changes in the module files, do not override the template
You have just copied and pasted the template override code provided by @ChristineWk
The title of the pull request becomes the message in the commit log. So it must be clear what it refers to or no one will ever see it in the future. If you look at the list of commits you should see why it is important https://github.com/joomla/joomla-cms/commits/4.1-dev
Title |
|
Please make changes in the module files, do not override the template You have just copied and pasted the template override code provided by @ChristineWk
I took the idea from it as i don't get the idea where files are stored related to it but i will try to do with other possible way
I have tested this item
unsuccessfull, because on clicking the logout icon ,the dropdown open which is not the expected result
I have tested this item
FYI this is semantically incorrect. You cannot have interactive elements inside a <button>
As explained several times already this should not be an override
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-08 08:44:07 |
Closed_By | ⇒ | prakhar3062 | |
Labels |
Added:
?
|
It should be a different button
see #37109 (comment)