User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) Front End Templates (site) |
Title |
|
Would you please give this pull request a meaningful title telling what it solves? And of course that title should not provide false information. The issue was not a bug but a feature request. Maybe you should do a research about what the word „bug“ means in software business.
Okay i changed the title
@richard67 i changed this file only administrator/templates/atum/html/mod_user/default.php
Other files are added by mistake. hoping it will help you in reviewing
@richard67 i changed this file only administrator/templates/atum/html/mod_user/default.php
Other files are added by mistake. hoping it will help you in reviewing
Sorry but with these unrelated changes this PR will not be accepted. You should get families with Git and GitHub.
@richard67 i changed this file only administrator/templates/atum/html/mod_user/default.php
Other files are added by mistake. hoping it will help you in reviewingSorry but with these unrelated changes this PR will not be accepted. You should get families with Git and GitHub.
i think but it will not distrub the configration it is just the part of the administrator template
@richard67 i changed this file only administrator/templates/atum/html/mod_user/default.php
Other files are added by mistake. hoping it will help you in reviewingSorry but with these unrelated changes this PR will not be accepted. You should get families with Git and GitHub.
i think but it will not distrub the configration it is just the part of the administrator template
I think you don’t know what a pull request is. When it will be merged, all changes in it will be merged. So a pull trauest shall not make unrelated changes or add unrelated files.
It cannot be accepted as it is.
@richard67 i changed this file only administrator/templates/atum/html/mod_user/default.php
Other files are added by mistake. hoping it will help you in reviewingSorry but with these unrelated changes this PR will not be accepted. You should get families with Git and GitHub.
i think but it will not distrub the configration it is just the part of the administrator template
I think you don’t know what a pull request is. When it will be merged, all changes in it will be merged. So a pull trauest shall not make unrelated changes or add unrelated files.
It cannot be accepted as it is.
okay what if deleted these extra files and then commit
Labels |
Added:
?
|
@richard67 is it now okay
Now it is even worse because you have deleted files which were not added by accident but were modified by accident, so the deletion is again an u wanted change. You should be able to see that when checking the changed files of your pull request on GitHub. There you would see that it still shows 7 modified files.
As stated before the changes should not be in the form of an override!!
I suggest you, first revert all the changes, then apply the changes you want and commit
OR Close this PR and then create a new PR
Category | Administration Templates (admin) Front End Templates (site) | ⇒ | Front End Templates (site) |
I suggest you, first revert all the changes, then apply the changes you want and commit OR Close this PR and then create a new PR
I revert the changes and commit again
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-02 03:47:20 |
Closed_By | ⇒ | prakhar3062 |
Would you please give this pull request a meaningful title telling what it solves? And of course that title should not provide false information. The issue was not a bug but a feature request. Maybe you should do a research about what the word „bug“ means in software business.