User tests: Successful: Unsuccessful:
Pull Request for Issue #37109
Put the logout button outside the dropdown menu.
After applying the patch, see the header of home page , you
No changes required
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) Installation Language & Strings |
Labels |
Added:
Language Change
?
|
I'm sure you didnt mean to delete 157 files from the installation ;)
This should NOT be an override
It seems he made an installation on his branch and removed the installation folder at the end and then checked in the complete branch
It seems he made an installation on his branch and removed the installation folder at the end and then checked in the complete branch
?
Actually at first i commit the change in my local repo then fetch it. It may be due to it
@prakhar3062 You still need to revert the change for deleting all the files in the installation folder.
It would also be better to create a separate branch for a PR an not use the 4.1-dev branch.
@prakhar3062 You still need to revert the change for deleting all the files in the installation folder.
how to revert the change
@prakhar3062 The best would be if you make in your fork a new branch based on the 4.1-dev branch of the upstream repository (= this here) and do your changes again on that branch, and then make a new PR with that branch and close this PR here in favour of the new PR. The 4.1-dev branch in your fork you should reset to the upstream.
See here https://docs.joomla.org/Working_with_git_and_github and here https://docs.joomla.org/Git_for_Coders and .
If you use an IDE for doing the Git stuff, check the help or online documentation of that.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-01 14:13:00 |
Closed_By | ⇒ | prakhar3062 |
@prakhar3062 Please fix the code style error reported by drone: https://ci.joomla.org/joomla/joomla-cms/52075/1/6