Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar prakhar3062
prakhar3062
1 Mar 2022

Pull Request for Issue #37109

Summary of Changes

Put the logout button outside the dropdown menu.

Testing Instructions

After applying the patch, see the header of home page , you

Actual result BEFORE applying this Pull Request

68747470733a2f2f6973737565732e6a6f6f6d6c612e6f72672f75706c6f6164732f312f39363334316334343432313938626239366230323562663934356465363136322e706e67

Expected result AFTER applying this Pull Request

Web capture_1-3-2022_153056_localhost

Documentation Changes Required

No changes required

3b797cf 1 Mar 2022 avatar prakhar3062 done
avatar prakhar3062 prakhar3062 - open - 1 Mar 2022
avatar prakhar3062 prakhar3062 - change - 1 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Mar 2022
Category Administration Templates (admin) Installation Language & Strings
avatar prakhar3062 prakhar3062 - change - 1 Mar 2022
The description was changed
avatar prakhar3062 prakhar3062 - edited - 1 Mar 2022
avatar prakhar3062 prakhar3062 - change - 1 Mar 2022
Labels Added: Language Change ?
avatar richard67
richard67 - comment - 1 Mar 2022

@prakhar3062 Please fix the code style error reported by drone: https://ci.joomla.org/joomla/joomla-cms/52075/1/6

avatar brianteeman
brianteeman - comment - 1 Mar 2022

I'm sure you didnt mean to delete 157 files from the installation ;)

avatar brianteeman
brianteeman - comment - 1 Mar 2022

This should NOT be an override

avatar richard67
richard67 - comment - 1 Mar 2022

It seems he made an installation on his branch and removed the installation folder at the end and then checked in the complete branch ?

avatar brianteeman
brianteeman - comment - 1 Mar 2022

hpover

avatar prakhar3062
prakhar3062 - comment - 1 Mar 2022

hpover

Oh i forgot to check by hovering over it

avatar prakhar3062
prakhar3062 - comment - 1 Mar 2022

It seems he made an installation on his branch and removed the installation folder at the end and then checked in the complete branch ?

Actually at first i commit the change in my local repo then fetch it. It may be due to it

avatar richard67
richard67 - comment - 1 Mar 2022

@prakhar3062 You still need to revert the change for deleting all the files in the installation folder.

avatar richard67
richard67 - comment - 1 Mar 2022

It would also be better to create a separate branch for a PR an not use the 4.1-dev branch.

avatar prakhar3062
prakhar3062 - comment - 1 Mar 2022

@prakhar3062 You still need to revert the change for deleting all the files in the installation folder.

how to revert the change

avatar richard67
richard67 - comment - 1 Mar 2022

@prakhar3062 The best would be if you make in your fork a new branch based on the 4.1-dev branch of the upstream repository (= this here) and do your changes again on that branch, and then make a new PR with that branch and close this PR here in favour of the new PR. The 4.1-dev branch in your fork you should reset to the upstream.

See here https://docs.joomla.org/Working_with_git_and_github and here https://docs.joomla.org/Git_for_Coders and .

If you use an IDE for doing the Git stuff, check the help or online documentation of that.

avatar prakhar3062 prakhar3062 - change - 1 Mar 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-03-01 14:13:00
Closed_By prakhar3062
avatar prakhar3062 prakhar3062 - close - 1 Mar 2022
avatar chmst
chmst - comment - 1 Mar 2022

It is not an issue, but an enhancement and new function.
There are valid comments for this RFC - you you could respect that, the result would be an extra button with an exit icon. Maybe you could try that? Something like that ...
grafik

Add a Comment

Login with GitHub to post a comment