a11y NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar akshitrattan
akshitrattan
26 Feb 2022

Pull Request for Issue #37117.

Summary of Changes

solved the first issue from the issue #37117, i.e. made the items in the media tree of the media manager, keyboard accessible

Testing Instructions

open the media manger of Joomla-CMS then click in the media tree section and press tab key
Press the right arrow key on any node to open it

Actual result BEFORE applying this Pull Request

You were not able to access any item of the media tree section using tab key

Expected result AFTER applying this Pull Request

You are able to access each item of the media tree section using tab key

Screenshot 2022-02-26 at 8 48 04 PM

Documentation Changes Required

No changes required.

avatar akshitrattan akshitrattan - open - 26 Feb 2022
avatar akshitrattan akshitrattan - change - 26 Feb 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2022
Category Administration com_media NPM Change
avatar akshitrattan akshitrattan - change - 26 Feb 2022
The description was changed
avatar akshitrattan akshitrattan - edited - 26 Feb 2022
avatar Quy
Quy - comment - 26 Feb 2022

Please read #35911 (comment).

avatar akshitrattan
akshitrattan - comment - 26 Feb 2022

Related #35911

so should I close the PR???

avatar Quy
Quy - comment - 26 Feb 2022

Please read the comment and try to fix it as the other PR is not the correct fix.

avatar akshitrattan
akshitrattan - comment - 26 Feb 2022

Please read the comment and try to fix it as the other PR is not the correct fix.

okay

Please read the comment and try to fix it as the other PR is not the correct fix.

I added the feature to open the media-tree folders using enter key, is it necessary to make them navigable using arrow keys because we do the same using tab and move up using shift + tab

avatar Quy
Quy - comment - 26 Feb 2022

Please see #35911 (comment)

avatar akshitrattan akshitrattan - change - 27 Feb 2022
Labels Added: NPM Resource Changed ?
avatar akshitrattan akshitrattan - change - 27 Feb 2022
The description was changed
avatar akshitrattan akshitrattan - edited - 27 Feb 2022
avatar brianteeman brianteeman - test_item - 1 Mar 2022 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 1 Mar 2022

I have tested this item ? unsuccessfully on b877bea

Now it is impossible to reach the tree at all using the keyboard :(

I added the feature to open the media-tree folders using enter key

That change doesnt work at all - the enter key does nothing.

And as stated before by @Quy please review the previous comments


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37152.

avatar akshitrattan
akshitrattan - comment - 1 Mar 2022

I have tested this item ? unsuccessfully on b877beaNow it is impossible to reach the tree at all using the keyboard :(

I added the feature to open the media-tree folders using enter key

That change doesnt work at all - the enter key does nothing.

And as stated before by @Quy please review the previous comments

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37152.

to open a node in the tree you now have to use the right arrow key, because it was mentioned in the comments of the PR #35911

avatar drmenzelit
drmenzelit - comment - 5 Mar 2022

to open a node in the tree you now have to use the right arrow key, because it was mentioned in the comments of the PR #35911

Please update the testing instructions accordingly

avatar akshitrattan akshitrattan - change - 5 Mar 2022
The description was changed
avatar akshitrattan akshitrattan - edited - 5 Mar 2022
avatar akshitrattan
akshitrattan - comment - 5 Mar 2022

to open a node in the tree you now have to use the right arrow key, because it was mentioned in the comments of the PR #35911

Please update the testing instructions accordingly

done

avatar akshitrattan
akshitrattan - comment - 13 Mar 2022

Screenshot 2022-03-13 at 12 52 52 PM

I added these lines of code for using the arrowkeys to navigate through the media-tree but I'm not able to make it work any suggestions would be really helpful
avatar Quy
Quy - comment - 22 Jun 2022

Closing in favor of #38126. Thank you.

avatar Quy Quy - close - 22 Jun 2022
avatar Quy Quy - change - 22 Jun 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-06-22 18:05:54
Closed_By Quy
Labels Added: a11y

Add a Comment

Login with GitHub to post a comment