[#37143] - Single-load of tags in category models
- Fixed in Code Base
- 6 Jun 2022
- Medium
- Build: 4.1-dev
- # 37143
- Diff
- Denitz:Single-load_of_tags_in_category_models
User tests: Successful: Unsuccessful:
Summary of Changes
Currently, frontend category models load tags separately per each item from the list of N items.
It results in N database queries.
The patch introduces new method Joomla\CMS\Helper\TagsHelper::getMultipleItemTags() which is executed only one time for all items and loads the tags of multiple items via one query.
Additionally, the patch has a simple code-cleanup and removes some deprecated JFactory calls.
Also declares the godforsaken Joomla\CMS\Helper\TagsHelper::$itemTags property.
Testing Instructions
Browse the frontend category views with tagged items for com_content, com_contact and com_newsfeeds.
Note the queries of pages.
Actual result BEFORE applying this Pull Request
Each item has its own separate query to load tags.
Expected result AFTER applying this Pull Request
All tags are loaded in a single query. See the number of queries is less by N-1.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact com_content com_newsfeeds Libraries |
| Labels |
Added:
?
|
||
@joomdonation All done, thanks!
I have tested this item
Works well. Thanks for working on this improvement.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37143.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37143.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37143.
Although I'm in favour of performance improvements, we should do it in 4.2.
I will rebase. Thanks for this PR!
| Labels |
Added:
?
|
||
@bembelimen Does it need new human tests, i.e. remove RTC, due to the rebase? I've restarted the failed drone and this time it succeeded.
| Labels |
Added:
?
Removed: ? |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-06 17:18:03 |
| Closed_By | ⇒ | roland-d |
Thanks everybody
I have tested this item✅ successfully on d04de31
Tested with com_content
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37143.