? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 Feb 2022

This PR makes the text for a radio or checkbox or list item required. It is needed for accessibility AND prevents you saving a field with empty radio or checkboxes or list items which are still rendered.

PR for #34337

Steps to reproduce

Create a field of type checkboxes.
Add one or two text / value pairs with content in text and value
Add another and leave text and value empty.

Repeat for a field of type radio
Repeat for a field of type list

Before

An empty checkbox or radio or list item is rendered

After

It is not possible to save the field until the checkbox or radio or list item has a text

fa9e217 25 Feb 2022 avatar brianteeman local
avatar brianteeman brianteeman - open - 25 Feb 2022
avatar brianteeman brianteeman - change - 25 Feb 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Feb 2022
Category Front End Plugins
avatar AndySDH
AndySDH - comment - 25 Feb 2022

Thanks. Same needs to be done for the 'list' field type as well.

avatar brianteeman brianteeman - change - 25 Feb 2022
Labels Added: ?
avatar brianteeman brianteeman - change - 25 Feb 2022
Title
[4.1] Empty radio and checkboxes
[4.1] Empty radio / checkbox / list fields
avatar brianteeman brianteeman - edited - 25 Feb 2022
avatar brianteeman brianteeman - change - 25 Feb 2022
The description was changed
avatar brianteeman brianteeman - edited - 25 Feb 2022
avatar brianteeman
brianteeman - comment - 25 Feb 2022

@AndySDH updated as requested

avatar Quy Quy - test_item - 25 Feb 2022 - Tested successfully
avatar Quy
Quy - comment - 25 Feb 2022

I have tested this item successfully on c679e36


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37138.

avatar chmst chmst - test_item - 26 Feb 2022 - Tested successfully
avatar chmst
chmst - comment - 26 Feb 2022

I have tested this item successfully on c679e36


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37138.

avatar chmst chmst - change - 26 Feb 2022
Status Pending Ready to Commit
avatar chmst
chmst - comment - 26 Feb 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37138.

avatar Quy Quy - change - 2 Mar 2022
Labels Added: ?
avatar bembelimen bembelimen - change - 7 Mar 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-03-07 12:27:55
Closed_By bembelimen
avatar bembelimen bembelimen - close - 7 Mar 2022
avatar bembelimen bembelimen - merge - 7 Mar 2022
avatar bembelimen
bembelimen - comment - 7 Mar 2022

Thx

avatar brianteeman
brianteeman - comment - 7 Mar 2022

thanks

Add a Comment

Login with GitHub to post a comment