? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Feb 2022

PR for #29533 (and more)

Since the component was changed to include the actual message in the email it is no longer a notification so I updated the description show in the mail templates component

image

Before this PR the subject of the email that was generated was

New Message from <user> at <sitename>

The actual subject of the message was included in the body of the email.
"New Message from " is not needed. We know who the email is from in the usual way and our inbox will show if it is new or not ;)

This also meant that you would have an inbox with multiple messages that all had the exact same title :(

image

With this PR the subject of the email that is generated is

[<sitename>] - Subject
and the body of the email only contains the body of the message not subject and body.

image

The messages can of course still be managed and updated with the mail templates component. This is just setting a better default.

avatar brianteeman brianteeman - open - 24 Feb 2022
avatar brianteeman brianteeman - change - 24 Feb 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2022
Category Administration Language & Strings
avatar brianteeman brianteeman - change - 24 Feb 2022
The description was changed
avatar brianteeman brianteeman - edited - 24 Feb 2022
avatar brianteeman brianteeman - change - 24 Feb 2022
The description was changed
avatar brianteeman brianteeman - edited - 24 Feb 2022
avatar brianteeman brianteeman - change - 24 Feb 2022
The description was changed
avatar brianteeman brianteeman - edited - 24 Feb 2022
avatar brianteeman brianteeman - change - 24 Feb 2022
The description was changed
avatar brianteeman brianteeman - edited - 24 Feb 2022
avatar tecpromotion
tecpromotion - comment - 5 Mar 2022

If the name of the website (sitename) is long, there is a risk that the subject will get lost in the background.
The idea is great but maybe you should turn it around? What do you think @brianteeman ?

avatar brianteeman
brianteeman - comment - 5 Mar 2022

I definitely want the sitename to be first for the exact scenario you suggest. If sitea is more important to me than siteb then I want to be sure that I can see which site it is in the message.

But as its configurable now then a user could change it as they see fit.

avatar tecpromotion
tecpromotion - comment - 6 Mar 2022

I have tested this item successfully on 7be569e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37133.

avatar tecpromotion tecpromotion - test_item - 6 Mar 2022 - Tested successfully
avatar Quy
Quy - comment - 7 Mar 2022

I have tested this item successfully on 7be569e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37133.

avatar Quy Quy - test_item - 7 Mar 2022 - Tested successfully
avatar Quy Quy - change - 7 Mar 2022
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 7 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37133.

avatar HLeithner HLeithner - change - 11 Mar 2022
Labels Added: ?
avatar HLeithner
HLeithner - comment - 11 Mar 2022

Thanks

avatar HLeithner HLeithner - change - 11 Mar 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-03-11 08:00:37
Closed_By HLeithner
Labels Added: Language Change
avatar HLeithner HLeithner - close - 11 Mar 2022
avatar HLeithner HLeithner - merge - 11 Mar 2022
avatar brianteeman
brianteeman - comment - 11 Mar 2022

thanks

Add a Comment

Login with GitHub to post a comment