? Language Change NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Feb 2022

This PR re-introduces the on screen instruction how to make codemirror full screen. (No idea why it was removed the pr doesnt help) AND fixes the positioning of the editor when full screen so that the first 5 lines are not hidden.

As there is a css change you will need to use a pre-build package or npm run build:css

Easiest to test in com_templates as that uses codemirror by default

avatar brianteeman brianteeman - open - 24 Feb 2022
avatar brianteeman brianteeman - change - 24 Feb 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2022
Category Administration Language & Strings Repository NPM Change Front End Plugins
avatar brianteeman brianteeman - change - 24 Feb 2022
Labels Added: Language Change NPM Resource Changed ?
avatar Quy
Quy - comment - 24 Feb 2022

How about float right to be subtle?

37129-codemirror

avatar brianteeman
brianteeman - comment - 25 Feb 2022

updated as requested

avatar Quy Quy - test_item - 25 Feb 2022 - Tested successfully
avatar Quy
Quy - comment - 25 Feb 2022

I have tested this item successfully on 95fd2bb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37129.

avatar jwaisner jwaisner - test_item - 26 Feb 2022 - Tested successfully
avatar jwaisner
jwaisner - comment - 26 Feb 2022

I have tested this item successfully on 95fd2bb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37129.

avatar jwaisner jwaisner - change - 26 Feb 2022
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 26 Feb 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37129.

avatar bembelimen bembelimen - change - 3 Mar 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-03-03 02:18:45
Closed_By bembelimen
Labels Added: ?
avatar bembelimen bembelimen - close - 3 Mar 2022
avatar bembelimen bembelimen - merge - 3 Mar 2022
avatar bembelimen
bembelimen - comment - 3 Mar 2022

Thx

avatar brianteeman
brianteeman - comment - 3 Mar 2022

Thanks

Add a Comment

Login with GitHub to post a comment