? ? Pending

User tests: Successful: Unsuccessful:

avatar nikosdion
nikosdion
23 Feb 2022

Pull Request for Issue #37122.

Summary of Changes

Modified the Joomla\CMS\Cache\Cache::setWorkarounds to do a special treatment of the WebAssetManager assets before they are cached when caching a module.

Testing Instructions

  • Install a new Joomla 4.1 site (I used the latest 4.1-dev as of February 23rd, 2022)
  • Do NOT install any sample data
  • Components, Contacts, Contacts, Add Your First Contact and create a contact in the Uncategorised group
  • Menus, Main Menu, New
    • Menu item type: Contacts, List All Categories in a Contact category Tree
    • Title: Contacts
    • Alias: contacts
  • Save & Close
  • System, Global Configuration and set the following in the System tab
    • System Cache: ON - Conservative Caching (VERY IMPORTANT! Do not use Progressive, that caching type makes it harder to reproduce the issue as I explain in the very long technical explanation below)
    • Cache Handler: File
    • Platform Specific Caching: No
    • Cache Time (minutes): 60
  • Click on Save & Close
  • System, Clear Cache, Delete All

Go to the frontend of your site and click through IN THIS EXACT ORDER:

  • Contacts
  • Uncategorised

Actual result BEFORE applying this Pull Request

Unsatisfied dependency "com_categories.shared-categories-accordion.es5" for an asset "com_categories.shared-categories-accordion" of type "script"

Expected result AFTER applying this Pull Request

I can see the contacts

Documentation Changes Required

None.

Important

Please look at the referenced issue's “Additional comments”. This can be a security issue for some sites.

avatar nikosdion nikosdion - open - 23 Feb 2022
avatar nikosdion nikosdion - change - 23 Feb 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Feb 2022
Category Libraries
avatar alikon alikon - test_item - 23 Feb 2022 - Tested successfully
avatar alikon
alikon - comment - 23 Feb 2022

I have tested this item successfully on 0ca2d71

i was able to replicate the issue under the "conditions"
mentioned and after applying the pathc and cleared all the cache's
the issue is fixed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37123.

avatar alikon
alikon - comment - 23 Feb 2022

I have tested this item successfully on 0ca2d71

i was able to replicate the issue under the "conditions"
mentioned and after applying the pathc and cleared all the cache's
the issue is fixed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37123.

avatar brianteeman brianteeman - test_item - 23 Feb 2022 - Tested successfully
avatar brianteeman
brianteeman - comment - 23 Feb 2022

I have tested this item successfully on 0ca2d71

Replicated the issue as reported
Applied the patch
Can no longer replicate the issue

Thank you


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37123.

avatar alikon alikon - change - 24 Feb 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 24 Feb 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37123.

avatar Quy Quy - change - 24 Feb 2022
Labels Added: ?
avatar nikosdion
nikosdion - comment - 25 Feb 2022

@alikon @brianteeman Can you please test #37139 with the same testing instructions I have here? (I will do the same later today) If #37139 works I'd prefer to have that one one merged instead of mine, as it would be addressing the underlying Joomla cache issue I explained yesterday in the comments of #37122.

avatar alikon alikon - change - 25 Feb 2022
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2022-02-25 17:34:41
Closed_By alikon
Labels Added: ?
avatar alikon
alikon - comment - 25 Feb 2022

so let's close this in favour of #37139 as requested

avatar alikon alikon - close - 25 Feb 2022

Add a Comment

Login with GitHub to post a comment