Feeling Lucky
?
?
[#37084] - [4.1] Fix: "Undefined variable $id"
- Fixed in Code Base
- 21 Feb 2022
- Medium
- Build: 4.1-dev
- # 37084
- Diff
- fluser:fix-undefined-var
User tests: Successful: Unsuccessful:
Regression of #35610.
Summary of Changes
This pull request changes from "elvis operator" to "null coalescing operator", which automatically includes an isset() and "not null" check.
"null coalescing operator" was introduced in PHP7.0 - as Joomla 4.1 requires min PHP7.2.5 this change should not break anything.
Testing Instructions
Joomla 4.1 / PHP8.0.15 in combination with iCagenda pro 3.8.0-beta2 custom fields.
Actual result BEFORE applying this Pull Request
Warning Message with custom fields from iCagenda:
Warning: Undefined variable $id in layouts/joomla/form/renderfield.php on line 37
Other extensions may be affected too.
Expected result AFTER applying this Pull Request
No warning message anymore
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Title |
|
||||||
chmst
- comment
- 18 Feb 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37084.
| Status | Pending | ⇒ | Ready to Commit |
chmst
- comment
- 18 Feb 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37084.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-21 18:14:26 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
?
|
||
bembelimen
- comment
- 21 Feb 2022
Thx
I have tested this item✅ successfully on b8045f7
Had the same issue with DPCalendar. This patch fixes it.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37084.