[#37069] - Remove empty spaces in classes
- Closed
- 11 Mar 2022
- Medium
- Build: 4.1-dev
- # 37069
- Diff
- RickR2H:4.1-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
In the category blog, featured blog, Cassiopeia module chromes there are empty spaces if no class is applied. This PR removes those spaces
Testing Instructions
- Install Joomla with the demo blog content
- Go to the homepage menu item "Home" and make sure to remove "Leading Article Classes" and "Article Classes"
- Set "# Leading Articles" and "# Intro Articles" both to 1
- Go to the homepage and see if the spaces are there
- Apply the patch an see if the spaces are gone
- Next apply classes an see if the required space is added
Do the same as above with the menu item "Blog" in the "Main Menu Blog" menu
The frontend module "Latest Posts" also has an empty space in the class name
The module uses the "Module Style" noCard
After applying the patch this space is gone.
Also try to add a module class suffix and see if the required space is added.
Next switch the "Module Style" to card
In the same place is also a space
Actual result BEFORE applying this Pull Request
There are spaces
Expected result AFTER applying this Pull Request
Spaces only applied if there is a class present
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content Templates (site) |
| Labels |
Added:
?
|
||
I have tested this item
I have tested this item successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37069.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37069.
I've restored the previous test results in the issue tracker since the commit after that was just a code style change (removal of an empty line).
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37069.
@richard67 Thanks!
Puhh, tbh I don't know....running a PHP function just for removing this spaces? It probably has only minor impact on performance, but I don't see the real benefit here.
Removing the spaces is cleaner and makes selecting html elements by css wildcard selectors easier. We could go back to the if then short hand which removes the function.
Other advantage is that classes are inserted without spaces. The old way of inserting classes was to add a leading space. With this PR this problem is solved.
| Labels |
Added:
?
|
||
After talking with several people I still think the benefit does not outweight all the negative points like added complexity, more PHP in html environment, server resources etc. So I'll close this one.
Thank you for your contribution.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-11 19:09:41 |
| Closed_By | ⇒ | bembelimen |
I have tested this item✅ successfully on 7c43394
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37069.