Feeling Lucky
?
[#37056] - [4.1] banner alias fix
- Closed
- 25 May 2022
- Medium
- Build: 4.1-dev
- # 37056
- Diff
- alikon:4.1-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #37031.
Summary of Changes
check for alias
Testing Instructions
Create a banner with the name "test1"
Create a second banner with the name "test1"
Actual result BEFORE applying this Pull Request
Both banners saved with the same alias
Expected result AFTER applying this Pull Request
Second banner gives an error message about duplicate alias
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners |
brianteeman
- comment
- 16 Feb 2022
I can confirm the patch works
BUT
I still can't see anywhere that the alias is used so there is no need for any check and if its not then we should not keep useless code
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37056.
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-05-25 11:48:33 |
| Closed_By | ⇒ | alikon |
I have tested this item✅ successfully on dc94f89
patch works
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37056.