Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar particthistle
particthistle
15 Feb 2022

Punctuation on line 92 resulted in .!

Identified in Crowdin by @dyfrig in crowdin comments.

Pull Request for issue in Crowdin

Summary of Changes

! removed at the end of the string.

Testing Instructions

Minor change - go to where PLG_SYSTEM_JOOA11Y_NEW_TAB_WARNING_TIP is used in the new Joomla 4.1 Accessibility Checker and see that the ! is removed at the end of the best practices link,

avatar particthistle particthistle - open - 15 Feb 2022
avatar particthistle particthistle - change - 15 Feb 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Feb 2022
Category Administration Language & Strings
avatar particthistle particthistle - change - 15 Feb 2022
The description was changed
avatar particthistle particthistle - edited - 15 Feb 2022
avatar particthistle particthistle - change - 15 Feb 2022
The description was changed
avatar particthistle particthistle - edited - 15 Feb 2022
avatar richard67
richard67 - comment - 15 Feb 2022

Hmm, why not do it the other way, leave the exclamation mark where it is and removing the full stop at the end of the anchor text?

avatar Quy
Quy - comment - 20 Feb 2022

Fixed/included in PR #37092. Thanks.

avatar Quy Quy - close - 20 Feb 2022
avatar Quy Quy - change - 20 Feb 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-02-20 18:20:53
Closed_By Quy
Labels Added: Language Change ?

Add a Comment

Login with GitHub to post a comment