? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
14 Feb 2022

Example settings were missing from this file

Code review only

avatar brianteeman brianteeman - open - 14 Feb 2022
avatar zero-24 zero-24 - change - 14 Feb 2022
Status New Ready to Commit
avatar zero-24
zero-24 - comment - 14 Feb 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37040.

avatar Quy Quy - change - 14 Feb 2022
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2022
Category Installation
avatar brianteeman
brianteeman - comment - 14 Feb 2022

I am closing this. @zero-24 you already refused to merge the floc change. I do not appreciate you making a change to my PR

avatar brianteeman brianteeman - change - 14 Feb 2022
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2022-02-14 19:40:10
Closed_By brianteeman
avatar brianteeman brianteeman - close - 14 Feb 2022
avatar zero-24
zero-24 - comment - 14 Feb 2022

@zero-24 you already refused to merge the floc change.

No that is not true the PR is just awaiting the 4.1.0 and 3.10.6 release which this PR would have been waiting for too.

I do not appreciate you making a change to my PR

My intention was to help you and not bother you with obvius changes. When you dont want maintainers to be allowed to do changes you can uncheck the option when creating the PR ;)

avatar zero-24
zero-24 - comment - 14 Feb 2022

New PR done here: #37041

Add a Comment

Login with GitHub to post a comment