[#37017] - [4.2] The alias is already being used - updates
- Fixed in Code Base
- 15 Oct 2022
- Medium
- Build: 4.2-dev
- # 37017
- Diff
- brianteeman:errormessage
User tests: Successful: Unsuccessful:
pr for #37013
create a menu item called test
Try to create a second menu item also called test
Before
After
It only says trashed if it is trashed and the link opens the existing menu item
Plus
Also updates com_content, com_categories, com_newsfeeds by splitting the message into two (one if the item is trashed). These are simpler changes as they dont have item names or links
Also updates com_finder filters to use a correct language string. Its not an article and it cant be trashed ;)
com_banners has not been updated because there is an existing bug in that #37031
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Libraries |
| Labels |
Added:
Language Change
?
|
||
You have to use a new language string else we get a fatal error without of sync languages
no you don't. Did you actually test it? If you did and you got a fatal error please post the stack trace.
Patch activated:
The patch could not be applied because it conflicts with a previously applied patch: administrator/language/en-GB/lib_joomla.ini
(4.1.0-rc5-dev)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37017.
I assume thats with patchtester? You cannot apply a patch on to an existing one. You need to rest first.
Of course have fetched before. And now resetted. Will try again.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37017.
Of course have fetched before. And now resetted. Will try again.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37017.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37017.
Result:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37017.
@brianteeman I see a chance to improve this message (as i have monochrome in backend I tried to cklick on all strong parts of the text).
What do you think about
where the string trashed is set only if the item is trashed?
@chmst unless I am very much mistaken the change to have two strings - one for trashed and one for regular items - is very easy. It was just lazy coding before to have that language string.
Once @HLeithner can confirm that he was wrong I will continue to work on this.
@brianteeman yes, otherwise it would be tricky. If the user has a link, he can see that the item ist trashed, so maybe it is not necessary to mention it at all
| Category | Administration Language & Strings Libraries | ⇒ | Administration com_contact Language & Strings Libraries |
| Category | Administration Language & Strings Libraries com_contact | ⇒ | Administration com_contact com_newsfeeds Language & Strings Libraries |
| Category | Administration Language & Strings Libraries com_contact com_newsfeeds | ⇒ | Administration com_contact com_finder com_newsfeeds Language & Strings Libraries |
| Category | Administration Language & Strings Libraries com_contact com_newsfeeds com_finder | ⇒ | Administration com_contact com_finder com_newsfeeds com_tags Language & Strings Libraries |
| Title |
|
||||||
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
|
||
Not sure if language files are updated on minor releases.
That should not be a blocker for things merged into 4.2 :)
Is this ever going to be merged?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-15 13:38:34 |
| Closed_By | ⇒ | roland-d |
Thanks
thanks
You have to use a new language string else we get a fatal error without of sync languages