? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
11 Feb 2022

Pull Request for Issue #37006 .

Summary of Changes

  • Change the field template layout to use the existing image JLayout

Testing Instructions

  • Add an image to an article via the Images and Links tab
  • Create a custom field of type Media then add an image via that field to an article
  • Inspect the result on the front end

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

NO

avatar dgrammatiko dgrammatiko - open - 11 Feb 2022
avatar dgrammatiko dgrammatiko - change - 11 Feb 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Feb 2022
Category Front End Plugins
avatar dgrammatiko dgrammatiko - change - 11 Feb 2022
The description was changed
avatar dgrammatiko dgrammatiko - edited - 11 Feb 2022
avatar dgrammatiko dgrammatiko - change - 11 Feb 2022
Labels Added: ?
avatar chmst chmst - test_item - 12 Feb 2022 - Tested successfully
avatar chmst
chmst - comment - 12 Feb 2022

I have tested this item successfully on 749070b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37008.

avatar Quy Quy - test_item - 12 Feb 2022 - Tested successfully
avatar Quy
Quy - comment - 12 Feb 2022

I have tested this item successfully on 749070b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37008.

avatar Quy Quy - change - 12 Feb 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 12 Feb 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37008.

avatar Scrabble96
Scrabble96 - comment - 14 Feb 2022

Is this going to be in the J4.1 release? It's passed checks but doesn't seem to have been merged.

avatar laoneo laoneo - change - 22 Feb 2022
Labels Added: ?
avatar laoneo laoneo - close - 22 Feb 2022
avatar laoneo laoneo - merge - 22 Feb 2022
avatar laoneo laoneo - change - 22 Feb 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-02-22 13:14:33
Closed_By laoneo
avatar laoneo
laoneo - comment - 22 Feb 2022

Thanks!

avatar Scrabble96
Scrabble96 - comment - 5 Feb 2023

I've just come back to this PR because when I checked a custom field of type 'Media' it still does not include the dimensions in the image's attributes.

Add a Comment

Login with GitHub to post a comment