? Pending

User tests: Successful: Unsuccessful:

avatar nikosdion
nikosdion
11 Feb 2022

Fixed the missing calls to opcache file invalidation as per the discussion in #36878

/cc @zero-24 @richard67

avatar nikosdion nikosdion - open - 11 Feb 2022
avatar nikosdion nikosdion - change - 11 Feb 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Feb 2022
Category Administration com_joomlaupdate
avatar zero-24 zero-24 - change - 11 Feb 2022
Labels Added: ?
avatar richard67 richard67 - test_item - 11 Feb 2022 - Tested successfully
avatar richard67
richard67 - comment - 11 Feb 2022

I have tested this item successfully on 9fd4766

I've tested lots of updates on that environment where I most of the times can reproduce the issue and could also today.

With the PR applied before the update, the issue did not happen anymore.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37003.

avatar richard67
richard67 - comment - 11 Feb 2022

@nikosdion Do you think that a similar change in the J4 extract.php could make sense? I don't see there that we do there what this PR here does. Or is that just at another place?

avatar nikosdion
nikosdion - comment - 11 Feb 2022

Joomla 4's extract.php already does that. The benefits of creating a purpose-built extraction feature instead of reusing generic code that's really written for restoring backups on empty servers ;)

avatar richard67
richard67 - comment - 11 Feb 2022

Joomla 4's extract.php already does that. The benefits of creating a purpose-built extraction feature instead of reusing generic code that's really written for restoring backups on empty servers ;)

@nikosdion Hmm, I did not see we do it on all extracted PHP files. But maybe I've just missed that when having looked quickly into the code.

avatar nikosdion
nikosdion - comment - 11 Feb 2022

@richard67 Look at ZIPExtraction::processLastExtractedFile which is called after we're done extracting a file. It calls clearFileInOPCache which calls opcache_invalidate for files with a .php extension. I think that you can follow the code backwards and reference the (documented!) constants to understand how it works.

avatar richard67
richard67 - comment - 11 Feb 2022

@richard67 Look at ZIPExtraction::processLastExtractedFile which is called after we're done extracting a file. It calls clearFileInOPCache which calls opcache_invalidate for files with a .php extension. I think that you can follow the code backwards and reference the (documented!) constants to understand how it works.

@nikosdion Thanks. Found it. Seems indeed to be ok.

avatar zero-24 zero-24 - test_item - 12 Feb 2022 - Tested successfully
avatar zero-24
zero-24 - comment - 12 Feb 2022

I have tested this item successfully on 9fd4766

I have just tested on my setup too so I think we are good to go here. Thanks @nikosdion ?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37003.

avatar zero-24 zero-24 - change - 12 Feb 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-02-12 16:03:04
Closed_By zero-24
avatar zero-24 zero-24 - close - 12 Feb 2022
avatar zero-24 zero-24 - merge - 12 Feb 2022
avatar richard67
richard67 - comment - 12 Feb 2022

Yes, I tested again today to make sure it also works on odd and not only even days on my weird environment, and it was all fine ? .

Add a Comment

Login with GitHub to post a comment