[#3700] - 3370_show_title_article_problem
- Closed
- 17 Dec 2015
- Medium
- Build: staging
- # 3700
- Diff
- Kixo:3370_params_articke_template_problem
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
The problem
No matter what I set the properties in the backend, the boolean value for "show_title" is always TRUE.
At first I edited "components\com_content\views\article\tmpl\default.php" Line 43:
-- get('show_title') || $params->get('show_author')) : ?>
++ get('show_title')&&$params->get('show_page_heading')) || $params->get('show_author')) : ?>
I know it is not a permanent solution, because that condition would be tied to two variables.
The solution
It will not break existing use case scenario but now user have the option to inherit Article options instead of Global options in that article.
I have made it possible for any option to be used in this way if it will be needed. It can be enabled by adding option COM_CONTENT_FIELD_VALUE_USE_ARTICLE_SETTINGS
Description pasted from original issue by Brian Teeman
Votes
| Title |
|
||||||
nicksavov
- | Labels |
Removed:
?
|
||
| Status | New | ⇒ | Pending |
I am closing this so that we only have one issue for the same topic #3370
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-09-19 11:22:59 |
Not sure that I agree with the PR, but now both are closed without reason!
| Rel_Number | ⇒ | 3700 | |
| Relation Type | ⇒ | Related to |
| Rel_Number | 3700 | ⇒ | 3370 |
Set to "open" on behalf of @elkuku by The JTracker Application at issues.joomla.org
| Status | Closed | ⇒ | Pending |
| Status | Pending | ⇒ | New |
I hope this was a number confusion ;)
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
Also, please change spaces to tabs in
+ <option value="use_article">COM_CONTENT_FIELD_VALUE_USE_ARTICLE_SETTINGS</option>
| Status | New | ⇒ | Pending |
@Kixo Sent you a pull request to add use Joomla\Registry\Registry; to the top of view.html.php
@ Other testers: if you get the error, add "use Joomla\Registry\Registry;" to the top of view.html.php.
@Test
Works. Adds an option "Use Article Settings" to menu item edit view for articles to use the "Show title" setting as defined in the article itself (not com_content options).
@HermanPeeren and I discussed it. We might want to discuss if this is the best solution UX wise. We should either add "Use Article Settings" for all options (not just title) or adjust "Use Global" name to "Use Article Settings" and adjust the function to always take the setting from the article, which could be "Use Global". The term "Use Global" might be better as "Use Global Article Settings".
@Kixo Can you look at the PR sent to you by @davdebcom so we can test this issue further?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3700.
| Status | Pending | ⇒ | Information Required |
Hello @Kixo
Thank you for your contribution.
The last comment here was on 21st August. Can you please update the pull request?
If no reply is received within 4 weeks we will close this issue.
Thanks for understanding!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3700.
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 2014-09-19 11:22:59 | ⇒ | 2015-12-17 11:08:49 |
| Closed_By | ⇒ | brianteeman |
Closed due to inactivity stated above.
It can always be reopened if needed
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3700.
http://issues.joomla.org/tracker/joomla-cms/3370