RTC NPM Resource Changed PR-4.1-dev

Pending

User tests: Successful: Unsuccessful:

avatar drmenzelit
drmenzelit
10 Feb 2022

Pull Request for Issues found by @woluweb
https://slides.woluweb.be/cassiopeia/cassiopeia.html#5-2-issue-2-the-read-more-button-partially-hidden
https://slides.woluweb.be/cassiopeia/cassiopeia.html#5-3-issue-3-layout-in-blog-view

Summary of Changes

Changed the _modifiers.scss file and added a media query for the code that controls the display of image and content on blog layout with images positioned left (image-left) or right (image-right) or alternating (image-alternate).

Testing Instructions

Create some articles with intro images and read more, at least one article with a very short text. Create a menu item of type category blog and use the classes image-left, image-right alone and in combination with image-alternate

Actual result BEFORE applying this Pull Request

See issues description on the links above
On mobiles: Read more buttons are not displaying completely, too much space between image and content, images over and below the text (by using class image-alternate)

Screenshot 2022-02-10 at 18-36-08 Blog

On desktops: By short text the position of the images is weird

Screenshot 2022-02-10 at 18-44-27 Blog

Expected result AFTER applying this Pull Request

Buttons are ok, no space between image and content, no weird distribution of image and content. Using image-alternate the image will display always on top of the article on mobiles

Screenshot 2022-02-10 at 19-33-31 Blog

Screenshot 2022-02-10 at 18-48-47 Blog

Documentation Changes Required

avatar drmenzelit drmenzelit - open - 10 Feb 2022
avatar drmenzelit drmenzelit - change - 10 Feb 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2022
Category Repository NPM Change
avatar drmenzelit drmenzelit - change - 10 Feb 2022
Title
Changed blog modifiers
[4.1] Changed blog modifiers on Cassiopeia
avatar drmenzelit drmenzelit - edited - 10 Feb 2022
avatar woluweb woluweb - test_item - 11 Feb 2022 - Tested successfully
avatar woluweb
woluweb - comment - 11 Feb 2022

I have tested this item successfully on f984443

Txs very much for taking the time of this PR @drmenzelit !
Tested successfully during our tests/exchanges yesterday on Glip on my own J4 site in construction.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36998.

avatar RickR2H RickR2H - test_item - 11 Feb 2022 - Tested successfully
avatar RickR2H
RickR2H - comment - 11 Feb 2022

I have tested this item successfully on f984443


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36998.

avatar RickR2H RickR2H - change - 11 Feb 2022
Status Pending Ready to Commit
Labels Added: PR-4.1-dev
avatar RickR2H
RickR2H - comment - 11 Feb 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36998.

avatar laoneo laoneo - change - 23 Feb 2022
Labels Added: RTC
avatar laoneo laoneo - close - 23 Feb 2022
avatar laoneo laoneo - merge - 23 Feb 2022
avatar laoneo laoneo - change - 23 Feb 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-02-23 06:32:45
Closed_By laoneo
Labels Added: NPM Resource Changed
avatar laoneo
laoneo - comment - 23 Feb 2022

Thanks!

Add a Comment

Login with GitHub to post a comment