No Code Attached Yet
avatar HarshJaiswani
HarshJaiswani
10 Feb 2022

Capture

Steps to reproduce the issue

Hit "npm run build:css" you will observe some warnings appearing.

Expected result

no warning should appear

Actual result

warnings about depriciated scss occurs

System information (as much as possible)

Additional comments

avatar HarshJaiswani HarshJaiswani - open - 10 Feb 2022
avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 10 Feb 2022
avatar dgrammatiko
dgrammatiko - comment - 10 Feb 2022
avatar HarshJaiswani
HarshJaiswani - comment - 10 Feb 2022

@dgrammatiko is it still open and can i help fix it ?

avatar dgrammatiko
dgrammatiko - comment - 10 Feb 2022

I closed it but feel free to reopen it.
BTW the fix requires upgrading to FontAwesome v6 which is still beta atm, that's why I closed the PR in the first place

avatar HarshJaiswani
HarshJaiswani - comment - 10 Feb 2022

@dgrammatiko yes there were some of that warnigns but some were also from build\media_source i have fixed them can i make a pull request of them ?

avatar brianteeman
brianteeman - comment - 10 Feb 2022

I closed it but feel free to reopen it. BTW the fix requires upgrading to FontAwesome v6 which is still beta atm, that's why I closed the PR in the first place

not any more

avatar dgrammatiko
dgrammatiko - comment - 10 Feb 2022

@HarshJaiswani I restored my PR. I will update it later to remove the changes for choices.js as they already patched it there

avatar richard67 richard67 - change - 10 Feb 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-02-10 14:43:21
Closed_By richard67
avatar richard67 richard67 - close - 10 Feb 2022
avatar richard67
richard67 - comment - 10 Feb 2022

Closing as having a pull request. Please test #36906 as soon as it has been updated by the change mentioned in the previous comment. Thanks in advance.

avatar richard67
richard67 - comment - 10 Feb 2022

@HarshJaiswani @dgrammatiko Shall PR #36992 be closed in favour of #36906 ?

Add a Comment

Login with GitHub to post a comment