Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar coolcat-creations
coolcat-creations
10 Feb 2022

This PR will change the label and description of the field for Administrator mails for the user settings.

Before:

grafik

I changed it to:

COM_USERS_CONFIG_FIELD_MAILTOADMIN_DESC="If set to Yes then a notification mail will be sent to all users who have receive system mails enabled if 'New User Account Activation' is set to 'None' or 'Self'."
COM_USERS_CONFIG_FIELD_MAILTOADMIN_LABEL="Send System-Mail"

Pull Request for Issue #36988 .

Testing Instructions

Install the patch and see that the labels are changed.

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

grafik

Documentation Changes Required

Yes it should be clarified that not only Administrators can get the mail

avatar coolcat-creations coolcat-creations - open - 10 Feb 2022
avatar coolcat-creations coolcat-creations - change - 10 Feb 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2022
Category Administration Language & Strings
avatar brianteeman
brianteeman - comment - 10 Feb 2022

Wouldn't it be a better fix to prevent system emails being sent to anyone who does not have admin interface access as the content of the system emails regularly contains links which require admin interface access.

For me this is just covering up the real issue and not actually solving it.

avatar coolcat-creations
coolcat-creations - comment - 10 Feb 2022

Yes, my skills were only able to solve one of the possibilities. But I think also that it would be good to only send this mails to users who have user administration admin rights. I see this as a huge GDPR issue for the website owners when they made this setting by mistake.

avatar coolcat-creations
coolcat-creations - comment - 10 Feb 2022

Another Possibilty would be to name System Mails to "Receive Administrator Mails"

avatar brianteeman
brianteeman - comment - 10 Feb 2022

Another Possibilty would be to name System Mails to "Receive Administrator Mails"

That is still just covering up the issue

avatar coolcat-creations
coolcat-creations - comment - 10 Feb 2022

Maybe we can continue here: #36988

avatar brianteeman
brianteeman - comment - 10 Feb 2022

Found the bug will do a PR later

avatar coolcat-creations
coolcat-creations - comment - 10 Feb 2022

You found a bug regarding this?
I think this database query is wrong but what to add to only get the admins that are allowed to controll users?

avatar brianteeman
brianteeman - comment - 10 Feb 2022

please test #36993

avatar coolcat-creations coolcat-creations - change - 10 Feb 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-02-10 14:09:12
Closed_By coolcat-creations
Labels Added: Language Change ?
avatar coolcat-creations coolcat-creations - close - 10 Feb 2022

Add a Comment

Login with GitHub to post a comment