[#36976] - [4.1] Resolve Com_contact_email bug in default_address.php
- Fixed in Code Base
- 28 Feb 2022
- Medium
- Build: 4.1-dev
- # 36976
- Diff
- prakhar3062:4.1-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #36957
COM_CONTACT_EMAIL issue created by [dzandut]
76 ">
Testing Instructions
Enable email display in contact form and then enter the any value and you will see the value
Actual result BEFORE applying this Pull Request
Instead of value of variable , variable name will appear
Expected result AFTER applying this Pull Request
Value of email will appear when you enable email display
Documentation Changes Required
Not at all
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
| Labels |
Added:
?
?
|
||
@prakhar3062 Please update the PR description
This is only partially complete. The language string is still missing
@rjharishabh sorry for trouble i have updated it now.
This is only partially complete. The language string is still missing
It is giving expected result in my system
Do you see COM_CONTACT_EMAIL when you view the source on the rendered page?
| Labels | |||
| Title |
|
||||||
Do you see COM_CONTACT_EMAIL when you view the source on the rendered page?
Yes sir
That means there is a language string missing then
@prakhar3062 would you like to complete this PR?
You can either change your language key to COM_CONTACT_EMAIL_LABEL, - this will be translated.
Or you can add a new line here for COM_CONTACT_EMAIL
https://github.com/joomla/joomla-cms/blob/4.1-dev/language/en-GB/com_contact.ini#L28
| Labels |
Added:
?
|
||
COM_CONTACT_EMAIL_LABEL
Thanks for reminding actually i was suffering with illness. Now i will try to contribute daily
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36976.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36976.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36976.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36976.
RTC???
RTC means this PR is ready to merge in the Joomla Core.
RTC - Ready To Commit
RTC means this PR is ready to merge in the Joomla Core. RTC - Ready To Commit
okay thanks for telling me
| Labels |
Added:
?
Removed: ? ? |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-28 16:23:48 |
| Closed_By | ⇒ | Quy |
Thanks.
When adding COM_CONTACT_EMAIL it's now showing "> after the translation...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36976.
I have tested this item
When adding COM_CONTACT_EMAIL it's now showing "> after the translation...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36976.
This is an old PR and was merged in 4.1.
You should be on 4.2.7 now, so that's a new issue. could you open a new one please? And give some more information about the language you are using and your exact Joomla Version.
@prakhar3062 please provide the test instructions and also add the issue number.