[#36972] - [4.1] [release blocker] The http head call returns a different structure than in J3
- Fixed in Code Base
- 8 Feb 2022
- Medium
- Build: 4.1-dev
- # 36972
- Diff
- zero-24:joomlaupdate_httperror
User tests: Successful: Unsuccessful:
Pull Request for Issue reported by Jenn Gress
This is an release blocker as without a patch for this issue no update is possible anymore.
Summary of Changes
The http head call returns a different structure than in J3
Within J3 it returns an string:
On J4 it returns an array of strings while that header can only have one value?
Testing Instructions
- Install 4.1.0-rc3
- set the update server to testing
- try to to reinistall 4.1.0-rc using the updater component
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Update works
Documentation Changes Required
none
cc @bembelimen
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
The commit message is "Set each header as an array of values instead of a string" it looks like it was intentional
The commit message is "Set each header as an array of values instead of a string" it looks like it was intentional
Sure it was meant to give some more context about what was changed that resulted into this behavior over the J3 behavior and why I was supprised about this change. ;)
I have tested this item
Tested patch in 4.1.0rc3 and PHP8.1 and it works.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36972.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36972.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36972.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-08 22:46:50 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
Thx
Ok the issue is this change within the framework: joomla-framework/http@07647b4
It changed the collection which from my understanding is an 1:1 mapping of header to value to and 1:x mapping where the x is an array.