[#36948] - [4.1] Use emojis vs google fonts for the accessibility plugin
- Fixed in Code Base
- 28 Feb 2022
- Medium
- Build: 4.1-dev
- # 36948
- Diff
- zero-24:useEmojis
User tests: Successful: Unsuccessful:
Pull Request for Issue #36928
Summary of Changes
Set "useEmojis" as recommended by the docs: https://ranbuch.github.io/accessibility/#icon-image
Testing Instructions
Apply this PR and make sure no google fonts are loaded when using the accessibility plugin
Actual result BEFORE applying this Pull Request
Before this change the default value is used which uses google fonts.
Expected result AFTER applying this Pull Request
We no longer use google fonts but emojis.
Documentation Changes Required
none
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36948.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36948.
Can you hold on merging this. The script has been broken upstream
Just checked and this change will actually resolve the bug upstream
| Labels |
Added:
?
|
||
@brianteeman so it is ok now to merge?
Well that depends. It has a side benefit of fixing #37050 which is an upstream bug. But it also exposes another upstream bug #37050 (comment) although thats much less severe.
But both issues are expected to be patched upstream right? So i would say this can go in while upstream issues still have to be tracked.
Is there an issue open we can reference here?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-28 12:57:36 |
| Closed_By | ⇒ | chmst |
Thanks
Thanks
I have tested this item✅ successfully on 53640b1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36948.