Feeling Lucky
?
NPM Resource Changed
?
[#36946] - [4.1] template previews need size restrictions
- Fixed in Code Base
- 3 Mar 2022
- Medium
- Build: 4.1-dev
- # 36946
- Diff
- brianteeman:template_thumbnail
User tests: Successful: Unsuccessful:
pr for #35498
If a template developer supplies a template_thumbnail.jpg that is oversized then it breaks the layout of the page.
To Test
- Delete media\templates\site\cassiopeia\images\template_thumbnail.png
- Copy media\templates\site\cassiopeia\images\template_preview.png to template_thumbnail.png
- Visit administrator/index.php?option=com_templates&view=templates&client_id=0 and you will see the oversized image
- Apply this pr (and
npm run build:cssor use a prebuilt package - Visit the url in step 3 and you will see the image displayed resized to fit the column
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
jwaisner
- comment
- 6 Feb 2022
@brianteeman , can you please sync this PR to the latest branch?
khu5h1
- comment
- 8 Feb 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36946.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 8 Feb 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36946.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-03 02:24:01 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
bembelimen
- comment
- 3 Mar 2022
Thx
brianteeman
- comment
- 3 Mar 2022
Thx
I have tested this item✅ successfully on ab7b8ce
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36946.