[#36930] - [4.2] Turn background image in MM into an img element
- Fixed in Code Base
- 10 Feb 2022
- Medium
- Build: 4.2-dev
- # 36930
- Diff
- Digital-Peak:j42/media/lazy-images
User tests: Successful: Unsuccessful:
Partial pull Request for Issue #36533.
Summary of Changes
Turns the element which shows an image in the media manager from a background div into a propper image element. Full credit for this pr goes to @dgrammatiko as he is the original author in #36550.
Testing Instructions
- Open the media manager list with the local adapter.
- Optionally you can also install the FTP adapter from DPmedia to test it with an external adapter.
Actual result BEFORE applying this Pull Request
Image is shown as background image.
Expected result AFTER applying this Pull Request
Image is shown as normal image with loading lazy attribute.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change Repository |
| Labels |
Added:
NPM Resource Changed
?
|
||
The SVG should display by adding src and removing loading, width, and height attributes.
All we have in the list is the thumb url, not the full url. But this issue also exists on the 4.2-dev branch. So it needs to be addressed separately. Because there is a general issue how to handle media without a thumbnail.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36930.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36930.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36930.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-10 20:56:02 |
| Closed_By | ⇒ | roland-d | |
| Labels |
Added:
?
|
||
Thank you,
In browser's console when displaying an SVG image.