No Code Attached Yet
avatar pnkr
pnkr
3 Feb 2022

Steps to reproduce the issue

Enabling this plugin tries to use Google Fonts
https://fonts.googleapis.com/icon?family=Material+Icons
through this css file /media/vendor/accessibility/js/accessibility.min.js?3.0.14

As of recent events Google Fonts breaches European law GDPR and should be optional.

Expected result

Plugin should be google font independent. So it should use a embeded font or another solution for icons.

Actual result

System information (as much as possible)

Joomla 4.0.6

Additional comments

avatar pnkr pnkr - open - 3 Feb 2022
avatar pnkr pnkr - change - 3 Feb 2022
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 3 Feb 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 3 Feb 2022
avatar zero-24
zero-24 - comment - 3 Feb 2022

Hmm looks like its a default option to use the remote font: https://github.com/ranbuch/accessibility/blob/09e9e21dadd5d0861c676cba008d8341533c2ef7/src/common.js#L75-L94
https://github.com/ranbuch/accessibility/blob/09e9e21dadd5d0861c676cba008d8341533c2ef7/src/main.js#L5-L6

But It looks like its possible to override it on the lib using end. But I'm not a JS expert to know how that could be done.

avatar zero-24
zero-24 - comment - 3 Feb 2022

Looks like we can pass the relevant options here: https://github.com/joomla/joomla-cms/blob/4.1-dev/plugins/system/accessibility/accessibility.php#L73 and that icons can be stored and served locally

avatar brianteeman
brianteeman - comment - 3 Feb 2022

Just read the docs!!!

avatar zero-24
zero-24 - comment - 3 Feb 2022

Yes the docs says we can set a option in the array. Now I pointed to the place where the options can be changed :)

avatar zero-24 zero-24 - change - 6 Feb 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-02-06 16:15:04
Closed_By zero-24
avatar zero-24 zero-24 - close - 6 Feb 2022
avatar zero-24
zero-24 - comment - 6 Feb 2022

PR created: #36948

Add a Comment

Login with GitHub to post a comment