Pending

User tests: Successful: Unsuccessful:

avatar elinw
elinw
9 Sep 2012
avatar elinw elinw - open - 9 Sep 2012
avatar mbabker
mbabker - comment - 9 Sep 2012

Just curious why we're using the <dd> tags for the addresses. If it's for accessibility or something, got it, but based on Bootstrap's docs, we shouldn't need those for an <address> element.

avatar realityking
realityking - comment - 9 Sep 2012

The adress element isn't actually meant for postal addresses (it has rather confusing semantics). From the HTML5 spec:

The address element represents the contact information for its nearest article or body element ancestor. If that is the body element, then the contact information applies to the document as a whole.

That said I wouldn't use a definition list either. The HTML5 spec suggests the following:

The address element must not be used to represent arbitrary addresses (e.g. postal addresses), unless those addresses are in fact the relevant contact information. (The p element is the appropriate element for marking up postal addresses in general.)
avatar elinw
elinw - comment - 10 Sep 2012

I didn't put the address element in, I found it there which I found a bit strange. As Rouven points out it has nothing to do with contact information. I'm happy to update the pr to take it out.

However, mainly I am just trying to get the lines not to run together.

Let's not act like we have to solve all problems in this layout (and there are many) in order to fix the misuse of nl2br.

The use of the icons as dt I thought was kind of interesting but strange unless you are going to have a text alternative. But again, this pr is not about fixing that, it is about getting line endings :).

It would indeed be good for someone to do the research on the correct semantics here but I tend to think dd dt is right. Any time you have label/ information pairs e.g. info block or address a dl makes sense. I don't really like this markup but I guess we have the multiple dds for one dt just for the address block and everything else will have its own.

I can't imagine how a p element would make sense, though in the example I guess they are saying you could either put each element in its own p or have a list inside the p (the way they show with the field labels) to have the elements render vertically as you would expect where you are trying not to impose one national style.

http://www.w3.org/TR/html5-author/the-dl-element.html
http://html5doctor.com/the-dl-element/

btw It's description list not definition list in html5.

avatar elinw elinw - close - 5 Oct 2012

Add a Comment

Login with GitHub to post a comment