? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
29 Jan 2022

Pull Request for Issue #36869

Summary of Changes

Make the headers check before the update download proxy aware by passing it via HttpFactory

Testing Instructions

First test

  • install 3.10.4
  • Apply this patch using com_patchtester
  • try to update to 3.10.5 using the default update channel. (please note the patch will be reverted by the update)

Second test

Third test

  • install 3.10.4
  • configure an proxy within the global configuration
  • Apply this patch using com_patchtester
  • try to update to 3.10.5 using the default update channel. (please note the patch will be reverted by the update)

Actual result BEFORE applying this Pull Request

Before the patch you can not update using the proxy setting as the get_headers call fails as it does not go via the proxy.

Expected result AFTER applying this Pull Request

Before and after the patch you can update without proxy but with that patch also with the proxy as we now go via the HTTPFactory vs get_headers directly.

Documentation Changes Required

none

cc @ThomasGarcia05 @richard67 @HLeithner

avatar zero-24 zero-24 - open - 29 Jan 2022
avatar zero-24 zero-24 - change - 29 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jan 2022
Category Administration com_joomlaupdate
avatar zero-24 zero-24 - change - 29 Jan 2022
The description was changed
avatar zero-24 zero-24 - edited - 29 Jan 2022
avatar chmst
chmst - comment - 2 Feb 2022

I made the first two tests, all fine.
The third test needs a proxy - unfortunately I cannot set up a proxy so could not perform the third test.

avatar zero-24
zero-24 - comment - 5 Feb 2022

Will merge here as there has been a test for that proxy thing by @ThomasGarcia05 here: #36869 (comment)

avatar zero-24 zero-24 - close - 5 Feb 2022
avatar zero-24 zero-24 - merge - 5 Feb 2022
avatar zero-24 zero-24 - change - 5 Feb 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-02-05 14:50:30
Closed_By zero-24
Labels Added: ?

Add a Comment

Login with GitHub to post a comment