? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
26 Jan 2022

Pull Request for Issue #34841.

Summary of Changes

The taxonomy names are not translated in the search results so far. Since we do translate them in the search form, it's just a matter of adding the right code. Please note that not all taxonomies types are always translated. It is expected that you provide translation overrides where necessary and to fix additional issues around this, there is #36748.

Testing Instructions

  1. Setup a site with content and smart search
  2. Enable debugging together with language debugging.
  3. Search in the frontend for something.

Actual result BEFORE applying this Pull Request

The taxonomies are listed, but the missins asterisks (*) show, that the strings aren't translated.

Expected result AFTER applying this Pull Request

The taxonomies are listed and now are either wrapped in asterisks or even show translation keys.

Note

I strongly suggest to only merge this when also #36748 is merged.

avatar Hackwar Hackwar - open - 26 Jan 2022
avatar Hackwar Hackwar - change - 26 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2022
Category Front End com_finder
avatar Kostelano Kostelano - test_item - 27 Jan 2022 - Tested successfully
avatar Kostelano
Kostelano - comment - 27 Jan 2022

I have tested this item successfully on 7e58afa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36863.

avatar Quy Quy - test_item - 29 Jan 2022 - Tested successfully
avatar Quy
Quy - comment - 29 Jan 2022

I have tested this item successfully on 7e58afa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36863.

avatar Quy Quy - change - 29 Jan 2022
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 29 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36863.

avatar Hackwar Hackwar - change - 2 Feb 2022
Labels Added: ?
avatar bembelimen bembelimen - change - 21 Feb 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-02-21 01:45:26
Closed_By bembelimen
avatar bembelimen bembelimen - close - 21 Feb 2022
avatar bembelimen bembelimen - merge - 21 Feb 2022
avatar bembelimen
bembelimen - comment - 21 Feb 2022

Thx

Add a Comment

Login with GitHub to post a comment