User tests: Successful: Unsuccessful:
Pull Request for Issue # none
This is the Joomla 4.1 identical correspondent pendent of the Joomla 3.10 PR #36804 that got merged, and replaces previous Joomla 4.0 PR #36761 that got outdated due to the cool refactoring of editors into Traits.
In PHP, htmlentities()
has following parameters types: 2nd is a non-null int, 4th is à non-null bool.
htmlentities(
string $string,
int $flags = ENT_QUOTES | ENT_SUBSTITUTE | ENT_HTML401,
?string $encoding = null,
bool $double_encode = true
): string
ref.: https://www.php.net/manual/en/function.htmlentities.php
This PR does replace null by their type-conversions: (int) null -> 0, and (bool) null -> false.
Disclaimer: I'm only fixing PHP 8.1 compatibility here.
A code-review should be enough here.
I found it with CB internal PMS / New Message, but I guess PHP 8.1 on any tinymce window should show it too.
This is the result on 4.0 (in 4.1-dev, it's erroring on line 380 of DisplayTrait.php instead of line 538 of tinymce.php):
No errors.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Plugins |
Labels |
Added:
?
|
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-24 20:10:31 |
Closed_By | ⇒ | bembelimen | |
Labels |
Added:
?
PHP 8.x
|
Thx
Please fix conflicts.