User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries Front End Plugins |
I do not agree. It uses the dispatcher which is new way. So should an empty event being introduced here or what?
So should an empty event being introduced here or what?
We have RFC for versioning joomla/rfc#29 (though it still RFC)
Changes that do not change signatures of functions or methods of the public API and do not add new ones can go
into a patch release.
New Event add a new public API, so it a new feature
And new feature should not go in RC.
This is not a signature change!
Correct, but a new public API.
Also can just change
onBeforeRespond
toonAfterRender
, that triggered almost before response.
Actually I do not care which event is used. If there is an existing one, then this pr can change to it and revert the "new" event. But reverting a whole pr which adds some debug functionality is just ridiculous.
This is not a signature change!
Correct, but a new public API.
Then make a pr which uses your suggested event and all is good. I will immediately test it.
Actually the original PR fixes a missing event (onBeforeRespond
) which already exists in the abstracted class WebApplication
(so it's not needed by allon to create the right event him self) but is missing in all abstracted and overridden classes. Beside this the event is also not triggered in the caching plugin and so would not add performance matrix when the page comes from the cache.
So I revert my opinion on reverting this PR since the event already exists, only the PR doesn't do what would be expected if the page is full cached because of the missing onBeforeRespond
in the caching plugin.
Keep in mind, this is only something which should work in debug mode and hopefully the caching plugin is not running when debugging.
Keep in mind, this is only something which should work in debug mode and hopefully the caching plugin is not running when debugging.
actually it does, looking at the code it also triggers the onAfterResponse
event only in debugmode:
https://github.com/joomla/joomla-cms/blob/4.1-dev/plugins/system/cache/cache.php#L147-L155
Wouldn't expect that...
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-25 13:36:34 |
Closed_By | ⇒ | bembelimen | |
Labels |
Added:
?
|
Also can just change
onBeforeRespond
toonAfterRender
, that triggered almost before response.