Joomla! Issue Tracker | Joomla! CMS #36838 - [4.1] remove fof from code comments

No Code Attached Yet

Closed
14 Nov 2022
Medium
Build: 4.1-dev
# 36838

brianteeman
25 Jan 2022

starts here

joomla-cms/administrator/components/com_postinstall/src/Model/MessagesModel.php

Lines 443 to 447 in 360409f

    
           	/** 
        
           	 * Adds or updates a post-installation message (PIM) definition. You can use this in your post-installation script using this code: 
        
           	 * 
        
           	 * require_once JPATH_LIBRARIES . '/fof/include.php'; 
        
           	 * FOFModel::getTmpInstance('Messages', 'PostinstallModel')->addPostInstallationMessage($options);

brianteeman - open - 25 Jan 2022

joomla-cms-bot - change - 25 Jan 2022

Labels

Added: No Code Attached Yet

joomla-cms-bot - labeled - 25 Jan 2022

brianteeman - change - 25 Jan 2022

The description was changed

brianteeman - edited - 25 Jan 2022

shagungarg0 - comment - 10 Feb 2022

is this issue only related to remove fof lines from comments?

brianteeman - comment - 10 Feb 2022

It means that the code comments need to be updated so that they are correct

joomdonation - comment - 14 Nov 2022

@brianteeman Are you interested to make the PR to correct the comment? We can replace the mentioned code with the new code below:

Factory::getApplication()->bootComponent('com_postinstall')
->getMVCFactory()->createModel('Messages', 'Administrator', ['ignore_request' => true])
->addPostInstallationMessage($options);

Thanks !

Hackwar - comment - 14 Nov 2022

I created a PR in #39214. Closing this issue.

Hackwar - change - 14 Nov 2022

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2022-11-14 10:03:37
Closed_By		⇒	Hackwar

Hackwar - close - 14 Nov 2022

brianteeman - comment - 14 Nov 2022

thanks

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#36838] - [4.1] remove fof from code comments

Add a Comment

	/**
	* Adds or updates a post-installation message (PIM) definition. You can use this in your post-installation script using this code:
	*
	* require_once JPATH_LIBRARIES . '/fof/include.php';
	* FOFModel::getTmpInstance('Messages', 'PostinstallModel')->addPostInstallationMessage($options);