[#36825] - [4.1] s/formater/formatter
- Closed
- 25 Jan 2022
- Medium
- Build: 4.1-dev
- # 36825
- Diff
- brianteeman:debug
User tests: Successful: Unsuccessful:
Use english not german
I think this also fixes a bug
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
There are more instances in other files.
Nevermind.
Hmm, maybe a typo in the maximebf/debugbar requires us to use that typo in our debug plugin? In this case this PR here would break debugging.
E.g. in libraries/vendor/maximebf/debugbar/src/DebugBar/DataCollector/MessagesCollector.php is used $this->dataFormater.
I have not tested this item.
Reverting my test since not sure anymore if it breaks debugging, since libraries/vendor/maximebf/debugbar has that typo, too. It could be just a copy and paste, or it could be that we use this 3rd party dependencies' objects, then we would have to keep that typo.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36825.
It breaks.
PHP Notice: Undefined property: Joomla\Plugin\System\Debug\DataCollector\SessionCollector::$dataFormatter in \plugins\system\debug\src\AbstractDataCollector.php on line 59
ok - closing as the upstream library is not under our control
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-25 18:40:52 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 91edb99
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36825.