User tests: Successful: Unsuccessful:
typo and fixes pagebreak plugin
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
RTC
Labels |
Added:
?
?
|
Thanks for the PR.
This has to be deprecated in 4.x - 0.1 before 5.0 to be changed in 5.0 to not break extensions using this (I know annoying..).
Why? The function is not changing just the default value for the $selector variable
Status | Ready to Commit | ⇒ | Pending |
Removed RTC
Why? The function is not changing just the default value for the $selector variable
Yeah, but if someone is calling it without setting any value, it uses the default value, which is probably not compatible anymore with JS/other code the user applied to this selector.
thats a lot of what ifs
I was just tyring to help - its not worth the hassle.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-01 22:53:10 |
Closed_By | ⇒ | brianteeman | |
Labels |
Added:
?
Removed: ? ? |
I have tested this item✅ successfully on a0e51f3
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36821.