? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Jan 2022

typo and fixes pagebreak plugin

avatar brianteeman brianteeman - open - 24 Jan 2022
avatar brianteeman brianteeman - change - 24 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jan 2022
Category Libraries
avatar richard67
richard67 - comment - 24 Jan 2022

I have tested this item successfully on a0e51f3

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36821.

avatar richard67 richard67 - test_item - 24 Jan 2022 - Tested successfully
avatar Quy Quy - test_item - 24 Jan 2022 - Tested successfully
avatar Quy
Quy - comment - 24 Jan 2022

I have tested this item successfully on a0e51f3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36821.

avatar Quy Quy - change - 24 Jan 2022
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 24 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36821.

avatar brianteeman brianteeman - change - 25 Jan 2022
Labels Added: ? ?
avatar bembelimen
bembelimen - comment - 31 Jan 2022

Thanks for the PR.

This has to be deprecated in 4.x - 0.1 before 5.0 to be changed in 5.0 to not break extensions using this (I know annoying..).

avatar brianteeman
brianteeman - comment - 31 Jan 2022

Why? The function is not changing just the default value for the $selector variable

avatar bembelimen bembelimen - change - 31 Jan 2022
Status Ready to Commit Pending
avatar bembelimen
bembelimen - comment - 31 Jan 2022

Removed RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36821.

avatar bembelimen
bembelimen - comment - 31 Jan 2022

Why? The function is not changing just the default value for the $selector variable

Yeah, but if someone is calling it without setting any value, it uses the default value, which is probably not compatible anymore with JS/other code the user applied to this selector.

avatar brianteeman
brianteeman - comment - 31 Jan 2022

thats a lot of what ifs

avatar brianteeman
brianteeman - comment - 1 Feb 2022

I was just tyring to help - its not worth the hassle.

avatar brianteeman brianteeman - change - 1 Feb 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-02-01 22:53:10
Closed_By brianteeman
Labels Added: ?
Removed: ? ?
avatar brianteeman brianteeman - close - 1 Feb 2022

Add a Comment

Login with GitHub to post a comment